Re: ext4: mballoc: avoid 20-argument function call

From	Theodore Ts'o <tytso@mit.edu>
Newsgroups	linux.kernel
Subject	Re: ext4: mballoc: avoid 20-argument function call
Date	2015-06-15 06:40 +0200
Message-ID	<pBulI-191-7@gated-at.bofh.it> (permalink)
References	<pzWFr-34b-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Jun 11, 2015 at 12:28:02AM +0200, Rasmus Villemoes wrote:
> Making a function call with 20 arguments is rather expensive in both
> stack and .text. In this case, doing the formatting manually doesn't
> make it any less readable, so we might as well save 155 bytes of .text
> and 112 bytes of stack.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ext4: mballoc: avoid 20-argument function call Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-06-11 00:30 +0200
  Re: ext4: mballoc: avoid 20-argument function call Theodore Ts'o <tytso@mit.edu> - 2015-06-15 06:40 +0200

csiph-web