Re: ext4: mballoc: avoid 20-argument function call

Path	csiph.com!aioe.org!bofh.it!news.nic.it!robomod
From	Theodore Ts'o <tytso@mit.edu>
Newsgroups	linux.kernel
Subject	Re: ext4: mballoc: avoid 20-argument function call
Date	Mon, 15 Jun 2015 06:40:02 +0200
Message-ID	<pBulI-191-7@gated-at.bofh.it> (permalink)
References	<pzWFr-34b-5@gated-at.bofh.it>
X-Original-To	Rasmus Villemoes <linux@rasmusvillemoes.dk>
Dkim-Signature	v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=thunk.org; s=ef5046eb; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date; bh=7qv25kHHe/evo5kEk8D3OtGMtre6oB1zjpl7U2Xypsw=; b=vPi6n4UjyC7iSK4r1Cc+VkGo0pz/kUiXHMeQa7g+2Bx0+WlaBF1wmJuay4HI/TVBIkNES8VCcL5u1m8ZNuYDdknWah+g2j5e6/H6MfYtyFsgqqzum6q1jBbmSbgz5+sHz9I455OYM9UI++NfG9m9FXq2aIFTnw6MHB9+UGRRYz4=;
Mail-Followup-To	Theodore Ts'o <tytso@mit.edu>, Rasmus Villemoes <linux@rasmusvillemoes.dk>, Andreas Dilger <adilger.kernel@dilger.ca>, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.23 (2014-03-12)
X-Sa-Exim-Connect-IP	<locally generated>
X-Sa-Exim-Mail-From	tytso@thunk.org
X-Sa-Exim-Scanned	No (on imap.thunk.org); SAEximRunCond expanded to false
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	16
Organization	linux.* mail to news gateway
X-Original-Cc	Andreas Dilger <adilger.kernel@dilger.ca>, linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Mon, 15 Jun 2015 00:36:05 -0400
X-Original-Message-ID	<20150615043605.GA15413@thunk.org>
X-Original-References	<1433975282-20694-1-git-send-email-linux@rasmusvillemoes.dk>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1165012

Show key headers only | View raw

On Thu, Jun 11, 2015 at 12:28:02AM +0200, Rasmus Villemoes wrote:
> Making a function call with 20 arguments is rather expensive in both
> stack and .text. In this case, doing the formatting manually doesn't
> make it any less readable, so we might as well save 155 bytes of .text
> and 112 bytes of stack.
> 
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>

Thanks, applied.

						- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ext4: mballoc: avoid 20-argument function call Rasmus Villemoes <linux@rasmusvillemoes.dk> - 2015-06-11 00:30 +0200
  Re: ext4: mballoc: avoid 20-argument function call Theodore Ts'o <tytso@mit.edu> - 2015-06-15 06:40 +0200

csiph-web