Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1165615

Re: [PATCH RFC v5 2/4] crypto: add PKE API

From Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups linux.kernel
Subject Re: [PATCH RFC v5 2/4] crypto: add PKE API
Date 2015-06-16 02:10 +0200
Message-ID <pBMBX-2r4-1@gated-at.bofh.it> (permalink)
References <pBJ1o-5xx-5@gated-at.bofh.it> <pBJ1o-5xx-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jun 15, 2015 at 01:18:42PM -0700, Tadeusz Struk wrote:
>
> +struct crypto_akcipher {
> +	void *key;

Having a void * pointer here is useless.  The normal way of doing
it is to place the key into the tfm context.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH RFC v5 0/4] crypto: Introduce Public Key Encryption API Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-15 22:20 +0200
  [PATCH RFC v5 3/4] crypto: rsa: add a new rsa generic implementation Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-15 22:20 +0200
  [PATCH RFC v5 2/4] crypto: add PKE API Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-15 22:20 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 01:50 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 01:50 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 02:00 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 02:00 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 02:10 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 02:10 +0200
  [PATCH RFC v5 4/4] crypto: add tests vectors for RSA Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-15 22:20 +0200
    Re: [PATCH RFC v5 4/4] crypto: add tests vectors for RSA Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 02:40 +0200

csiph-web