Re: [PATCH RFC v5 2/4] crypto: add PKE API

Path	csiph.com!aioe.org!gothmog.csi.it!bofh.it!news.nic.it!robomod
From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: [PATCH RFC v5 2/4] crypto: add PKE API
Date	Tue, 16 Jun 2015 02:10:01 +0200
Message-ID	<pBMBX-2r4-1@gated-at.bofh.it> (permalink)
References	<pBJ1o-5xx-5@gated-at.bofh.it> <pBJ1o-5xx-17@gated-at.bofh.it>
X-Original-To	Tadeusz Struk <tadeusz.struk@intel.com>
MIME-Version	1.0
Content-Type	text/plain; charset=us-ascii
Content-Disposition	inline
User-Agent	Mutt/1.5.21 (2010-09-15)
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	18
Organization	linux.* mail to news gateway
X-Original-Cc	linux-kernel@vger.kernel.org, keescook@chromium.org, jwboyer@redhat.com, smueller@chronox.de, richard@nod.at, steved@redhat.com, qat-linux@intel.com, dhowells@redhat.com, linux-crypto@vger.kernel.org, james.l.morris@oracle.com, jkosina@suse.cz, zohar@linux.vnet.ibm.com, davem@davemloft.net, vgoyal@redhat.com
X-Original-Date	Tue, 16 Jun 2015 07:59:54 +0800
X-Original-Message-ID	<20150615235954.GC16562@gondor.apana.org.au>
X-Original-References	<20150615201831.15697.57738.stgit@tstruk-mobl1> <20150615201842.15697.59701.stgit@tstruk-mobl1>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	aioe.org linux.kernel:1165615

Show key headers only | View raw

On Mon, Jun 15, 2015 at 01:18:42PM -0700, Tadeusz Struk wrote:
>
> +struct crypto_akcipher {
> +	void *key;

Having a void * pointer here is useless.  The normal way of doing
it is to place the key into the tfm context.

Cheers,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Thread

[PATCH RFC v5 0/4] crypto: Introduce Public Key Encryption API Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-15 22:20 +0200
  [PATCH RFC v5 3/4] crypto: rsa: add a new rsa generic implementation Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-15 22:20 +0200
  [PATCH RFC v5 2/4] crypto: add PKE API Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-15 22:20 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 01:50 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 01:50 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 02:00 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 02:00 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 02:10 +0200
    Re: [PATCH RFC v5 2/4] crypto: add PKE API Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 02:10 +0200
  [PATCH RFC v5 4/4] crypto: add tests vectors for RSA Tadeusz Struk <tadeusz.struk@intel.com> - 2015-06-15 22:20 +0200
    Re: [PATCH RFC v5 4/4] crypto: add tests vectors for RSA Herbert Xu <herbert@gondor.apana.org.au> - 2015-06-16 02:40 +0200

csiph-web