Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > comp.lang.python > #80232

Re: Code review

From John Gordon <gordon@panix.com>
Newsgroups comp.lang.python
Subject Re: Code review
Date 2014-11-04 20:35 +0000
Organization PANIX Public Access Internet and UNIX, NYC
Message-ID <m3bda8$fui$1@reader1.panix.com> (permalink)
References <mailman.15454.1415115015.18130.python-list@python.org>

Show all headers | View raw


C Smith <illusiontechniques@gmail.com> writes:

> I was wondering if I could get some feedback on the biggest thing I
> have done as an amateur Python coder.

Comments.

You need a *lot* more comments.

Like, every line or two of code should have a comment explaining what is
being accomplished.  Seriously.  Every line or two.

Some blank lines wouldn't hurt either.

Also it would be nice to define some of the terms you're using.  What is
a blind?  What does "in front" mean?  What is a "muck hand"?

-- 
John Gordon         Imagine what it must be like for a real medical doctor to
gordon@panix.com    watch 'House', or a real serial killer to watch 'Dexter'.

Back to comp.lang.python | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

Code review C Smith <illusiontechniques@gmail.com> - 2014-11-04 07:28 -0800
  Re: Code review John Gordon <gordon@panix.com> - 2014-11-04 20:35 +0000
    Re: Code review sohcahtoa82@gmail.com - 2014-11-04 16:09 -0800
      Re: Code review C Smith <illusiontechniques@gmail.com> - 2014-11-04 22:23 -0800

csiph-web