Path: csiph.com!v102.xanadu-bbs.net!xanadu-bbs.net!feeder.erje.net!us.feeder.erje.net!news.snarked.org!news.linkpendium.com!news.linkpendium.com!panix!gordon From: John Gordon Newsgroups: comp.lang.python Subject: Re: Code review Date: Tue, 4 Nov 2014 20:35:20 +0000 (UTC) Organization: PANIX Public Access Internet and UNIX, NYC Lines: 21 Message-ID: References: NNTP-Posting-Host: panix3.panix.com X-Trace: reader1.panix.com 1415133320 16338 166.84.1.3 (4 Nov 2014 20:35:20 GMT) X-Complaints-To: abuse@panix.com NNTP-Posting-Date: Tue, 4 Nov 2014 20:35:20 +0000 (UTC) User-Agent: nn/6.7.3 Xref: csiph.com comp.lang.python:80232 C Smith writes: > I was wondering if I could get some feedback on the biggest thing I > have done as an amateur Python coder. Comments. You need a *lot* more comments. Like, every line or two of code should have a comment explaining what is being accomplished. Seriously. Every line or two. Some blank lines wouldn't hurt either. Also it would be nice to define some of the terms you're using. What is a blind? What does "in front" mean? What is a "muck hand"? -- John Gordon Imagine what it must be like for a real medical doctor to gordon@panix.com watch 'House', or a real serial killer to watch 'Dexter'.