Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > comp.lang.javascript > #16295

Re: document.elementname vs document.getElementById("id")

Show all headers | View raw

On Mon, 01 Oct 2012 06:23:13 +0300, Jukka K. Korpela wrote:

> 2012-10-01 1:07, Denis McMahon wrote:
> 
>> Very Senior Coder decided it needed fixing because it was broken on his
>> choice of browser / platform, so he made it work for him.
> [...]
>> I won the argument of to fix or not to fix by sending him the list of
>> W3C validator errors
> 
> This seems to say that you persuaded him to fix it after he had fixed
> it. Apparently, Very Senior Coder was at some point using a Firefox
> version that refuses to recognize document.all in "standards" mode. Or
> maybe he was fixing something completely different and happened to
> change document.all.formname to document.formname en passant. It often
> happens that we think we fixed something by doing something specific but
> actually changed a lot of things and the thing that fixed our problem
> was a different one.

He said the only change he made was in the js, changing 
document.all.formname to document.formname. The RCS logs tend to confirm 
that this was the only change he made:

rcsdiff -r1.9 -r1.8 .../runtime_browser.c
===================================================================
RCS file: .../RCS/runtime_browser.c,v
retrieving revision 1.9
retrieving revision 1.8
diff -r1.9 -r1.8
270c270
<               "document.choose_runtime.innerHTML = "
---
>               "document.all.choose_runtime.innerHTML = "

The previous change to the file was in 2009, and the subsequent one was 
my xhtml validation fixes, so I'm pretty sure that what he said he did 
was what he actually did. ;)

The argument I won was to not use the name attribute in the form at all, 
because we're serving the pages as xhtml 1.0 strict and there is no name 
attribute for a form element in that dtd!

>> If we're serving a page claiming to be validated xhtml 1.0 strict, then
>> IMO it had damn well better validate.
> 
> Whether it validates or not has as such nothing to do with how it works
> on browsers. The presence of a doctype only affects the mode of the
> browser (mainly "quirks" vs. "standards"), but for this, it is
> completely immaterial whether the markup conforms to the document type
> definition.

Agreed, but if the page is broken, making sure the (x)html is valid to 
the dtd is always a good starting point.

Rgds

Denis McMahon

Back to comp.lang.javascript | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

document.elementname vs document.getElementById("id") Denis McMahon <denismfmcmahon@gmail.com> - 2012-09-29 18:15 +0000
  Re: document.elementname vs document.getElementById("id") Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2012-09-29 22:17 +0200
  Re: document.elementname vs document.getElementById("id") dann90038@gmail.com - 2012-09-29 16:21 -0700
  Re: document.elementname vs document.getElementById("id") "J.R." <groups_jr-1@yahoo.com.br> - 2012-09-29 23:20 -0300
    Re: document.elementname vs document.getElementById("id") "J.R." <groups_jr-1@yahoo.com.br> - 2012-09-29 19:53 -0700
    Re: document.elementname vs document.getElementById("id") "Jukka K. Korpela" <jkorpela@cs.tut.fi> - 2012-09-30 11:02 +0300
      Re: document.elementname vs document.getElementById("id") Denis McMahon <denismfmcmahon@gmail.com> - 2012-09-30 13:10 +0000
      Re: document.elementname vs document.getElementById("id") Denis McMahon <denismfmcmahon@gmail.com> - 2012-09-30 13:14 +0000
        Re: document.elementname vs document.getElementById("id") "Jukka K. Korpela" <jkorpela@cs.tut.fi> - 2012-09-30 17:20 +0300
          Re: document.elementname vs document.getElementById("id") Eric Bednarz <bednarz@fahr-zur-hoelle.org> - 2012-09-30 21:09 +0200
            Re: document.elementname vs document.getElementById("id") "Jukka K. Korpela" <jkorpela@cs.tut.fi> - 2012-09-30 22:28 +0300
              Re: document.elementname vs document.getElementById("id") Eric Bednarz <bednarz@fahr-zur-hoelle.org> - 2012-09-30 21:53 +0200
            Re: document.elementname vs document.getElementById("id") Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2012-09-30 21:53 +0200
          Re: document.elementname vs document.getElementById("id") Denis McMahon <denismfmcmahon@gmail.com> - 2012-09-30 22:07 +0000
            Re: document.elementname vs document.getElementById("id") "Jukka K. Korpela" <jkorpela@cs.tut.fi> - 2012-10-01 06:23 +0300
              Re: document.elementname vs document.getElementById("id") Denis McMahon <denismfmcmahon@gmail.com> - 2012-10-01 08:11 +0000
                Re: document.elementname vs document.getElementById("id") Stefan Weiss <krewecherl@gmail.com> - 2012-10-01 11:25 +0200
      Re: document.elementname vs document.getElementById("id") "J.R." <groups_jr-1@yahoo.com.br> - 2012-09-30 15:10 -0300
        Re: document.elementname vs document.getElementById("id") Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2012-09-30 20:43 +0200
    Re: document.elementname vs document.getElementById("id") Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2012-09-30 12:22 +0200
      Re: document.elementname vs document.getElementById("id") "Jukka K. Korpela" <jkorpela@cs.tut.fi> - 2012-09-30 13:44 +0300
        Re: document.elementname vs document.getElementById("id") Thomas 'PointedEars' Lahn <PointedEars@web.de> - 2012-09-30 13:46 +0200
  Re: document.elementname vs document.getElementById("id") Dr J R Stockton <reply1239@merlyn.demon.co.uk.invalid> - 2012-09-30 20:10 +0100

csiph-web