Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742657 > unrolled thread

[PATCH] thunderbolt: make tb_domain_type const

Back to article view | Back to linux.kernel

Contents

  [PATCH] thunderbolt: make tb_domain_type const Bhumika Goyal <bhumirks@gmail.com> - 2017-09-30 18:40 +0200
    Re: [PATCH] thunderbolt: make tb_domain_type const Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-10-02 11:40 +0200

#1742657 — [PATCH] thunderbolt: make tb_domain_type const

Make this const as it is only stored in the const field of a device
structure. Make the declaration in header const too.

Structure found using Coccinelle and changes done by hand.

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
---
 drivers/thunderbolt/domain.c | 2 +-
 drivers/thunderbolt/tb.h     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thunderbolt/domain.c b/drivers/thunderbolt/domain.c
index 9f2dcd4..f8b11a3 100644
--- a/drivers/thunderbolt/domain.c
+++ b/drivers/thunderbolt/domain.c
@@ -65,7 +65,7 @@ static void tb_domain_release(struct device *dev)
 	kfree(tb);
 }
 
-struct device_type tb_domain_type = {
+const struct device_type tb_domain_type = {
 	.name = "thunderbolt_domain",
 	.release = tb_domain_release,
 };
diff --git a/drivers/thunderbolt/tb.h b/drivers/thunderbolt/tb.h
index e0deee4..fa65049 100644
--- a/drivers/thunderbolt/tb.h
+++ b/drivers/thunderbolt/tb.h
@@ -369,7 +369,7 @@ static inline int tb_port_write(struct tb_port *port, const void *buffer,
 struct tb *tb_probe(struct tb_nhi *nhi);
 
 extern struct bus_type tb_bus_type;
-extern struct device_type tb_domain_type;
+extern const struct device_type tb_domain_type;
 extern struct device_type tb_switch_type;
 
 int tb_domain_init(void);
-- 
1.9.1

[toc] | [next] | [standalone]

#1743064

On Sat, Sep 30, 2017 at 10:07:12PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the const field of a device
> structure. Make the declaration in header const too.
> 
> Structure found using Coccinelle and changes done by hand.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

This looks good. However, I'm currently doing some shuffling in
drivers/thunderbolt/tb.h to get Thunderbolt services supported which
makes this patch not to apply cleanly anymore:

https://lkml.org/lkml/2017/9/25/225

I wonder if you could rebase your patch on top of that?

Also please Cc Greg as well.

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web