Re: [PATCH] thunderbolt: make tb_domain_type const

From	Mika Westerberg <mika.westerberg@linux.intel.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] thunderbolt: make tb_domain_type const
Date	2017-10-02 11:40 +0200
Message-ID	<uw5mG-5Bp-5@gated-at.bofh.it> (permalink)
References	<uvsY1-6AR-11@gated-at.bofh.it>
Organization	Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

Show all headers | View raw

On Sat, Sep 30, 2017 at 10:07:12PM +0530, Bhumika Goyal wrote:
> Make this const as it is only stored in the const field of a device
> structure. Make the declaration in header const too.
> 
> Structure found using Coccinelle and changes done by hand.
> 
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

This looks good. However, I'm currently doing some shuffling in
drivers/thunderbolt/tb.h to get Thunderbolt services supported which
makes this patch not to apply cleanly anymore:

https://lkml.org/lkml/2017/9/25/225

I wonder if you could rebase your patch on top of that?

Also please Cc Greg as well.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] thunderbolt: make tb_domain_type const Bhumika Goyal <bhumirks@gmail.com> - 2017-09-30 18:40 +0200
  Re: [PATCH] thunderbolt: make tb_domain_type const Mika Westerberg <mika.westerberg@linux.intel.com> - 2017-10-02 11:40 +0200

csiph-web