Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742055 > unrolled thread

[PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event

Back to article view | Back to linux.kernel

Contents

  [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event Jan Kiszka <jan.kiszka@siemens.com> - 2017-09-29 13:30 +0200
    Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event Jan Kiszka <jan.kiszka@siemens.com> - 2017-09-29 14:00 +0200
      Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event Steven Rostedt <rostedt@goodmis.org> - 2017-09-29 15:10 +0200

#1742055 — [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event

From: Jan Kiszka <jan.kiszka@siemens.com>

Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
---

I didn't manage to test this so far, but this looked strange while
reading the code.

 trace-view-store.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/trace-view-store.c b/trace-view-store.c
index 2ec52c8..f5d0a04 100644
--- a/trace-view-store.c
+++ b/trace-view-store.c
@@ -1254,7 +1254,7 @@ static void update_filter_tasks(TraceViewStore *store)
 						      "pid");
 
 		store->sched_wakeup_new_event =
-			pevent_find_event_by_name(pevent, "sched", "sched_wakeup");
+			pevent_find_event_by_name(pevent, "sched", "sched_wakeup_new");
 		if (store->sched_wakeup_new_event)
 			store->sched_wakeup_new_pid_field =
 				pevent_find_any_field(store->sched_wakeup_new_event,
-- 
2.12.3

[toc] | [next] | [standalone]

#1742069

On 2017-09-29 13:29, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> I didn't manage to test this so far, but this looked strange while
> reading the code.

Now I found out how it is supposed to work and can confirm that this
patch fixes a real bug.

Jan

> 
>  trace-view-store.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/trace-view-store.c b/trace-view-store.c
> index 2ec52c8..f5d0a04 100644
> --- a/trace-view-store.c
> +++ b/trace-view-store.c
> @@ -1254,7 +1254,7 @@ static void update_filter_tasks(TraceViewStore *store)
>  						      "pid");
>  
>  		store->sched_wakeup_new_event =
> -			pevent_find_event_by_name(pevent, "sched", "sched_wakeup");
> +			pevent_find_event_by_name(pevent, "sched", "sched_wakeup_new");
>  		if (store->sched_wakeup_new_event)
>  			store->sched_wakeup_new_pid_field =
>  				pevent_find_any_field(store->sched_wakeup_new_event,
> 

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

[toc] | [prev] | [next] | [standalone]

#1742089

On Fri, 29 Sep 2017 13:49:31 +0200
Jan Kiszka <jan.kiszka@siemens.com> wrote:

> On 2017-09-29 13:29, Jan Kiszka wrote:
> > From: Jan Kiszka <jan.kiszka@siemens.com>
> > 
> > Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
> > 
> > Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> > ---
> > 
> > I didn't manage to test this so far, but this looked strange while
> > reading the code.  
> 
> Now I found out how it is supposed to work and can confirm that this
> patch fixes a real bug.
> 

Thanks Jan,

I'm currently at Kernel Recipes and my time for adding patches is
extremely limited while traveling. I'll hopefully be able to get to all
this next week.

-- Steve

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web