Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1742069

Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event

Show all headers | View raw

On 2017-09-29 13:29, Jan Kiszka wrote:
> From: Jan Kiszka <jan.kiszka@siemens.com>
> 
> Seems like a copy&paste bug of the initial commit 7b0139ebb1cf.
> 
> Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> ---
> 
> I didn't manage to test this so far, but this looked strange while
> reading the code.

Now I found out how it is supposed to work and can confirm that this
patch fixes a real bug.

Jan

> 
>  trace-view-store.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/trace-view-store.c b/trace-view-store.c
> index 2ec52c8..f5d0a04 100644
> --- a/trace-view-store.c
> +++ b/trace-view-store.c
> @@ -1254,7 +1254,7 @@ static void update_filter_tasks(TraceViewStore *store)
>  						      "pid");
>  
>  		store->sched_wakeup_new_event =
> -			pevent_find_event_by_name(pevent, "sched", "sched_wakeup");
> +			pevent_find_event_by_name(pevent, "sched", "sched_wakeup_new");
>  		if (store->sched_wakeup_new_event)
>  			store->sched_wakeup_new_pid_field =
>  				pevent_find_any_field(store->sched_wakeup_new_event,
> 

-- 
Siemens AG, Corporate Technology, CT RDA ITP SES-DE
Corporate Competence Center Embedded Linux

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event Jan Kiszka <jan.kiszka@siemens.com> - 2017-09-29 13:30 +0200
  Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event Jan Kiszka <jan.kiszka@siemens.com> - 2017-09-29 14:00 +0200
    Re: [PATCH][trace-cmd] trace-view: Pick up sched_wakeup_new event Steven Rostedt <rostedt@goodmis.org> - 2017-09-29 15:10 +0200

csiph-web