Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1740447 > unrolled thread
| Started by | Oliver Neukum <oneukum@suse.com> |
|---|---|
| First post | 2017-09-27 09:20 +0200 |
| Last post | 2017-09-29 02:00 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id Oliver Neukum <oneukum@suse.com> - 2017-09-27 09:20 +0200
Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id Grant Grundler <grundler@chromium.org> - 2017-09-27 18:40 +0200
Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id "Rustad, Mark D" <mark.d.rustad@intel.com> - 2017-09-29 00:30 +0200
Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id Doug Anderson <dianders@chromium.org> - 2017-09-29 02:00 +0200
| From | Oliver Neukum <oneukum@suse.com> |
|---|---|
| Date | 2017-09-27 09:20 +0200 |
| Subject | Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id |
| Message-ID | <uueNs-7BL-23@gated-at.bofh.it> |
Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: > > I know that for at least some of the adapters in the CDC Ethernet > blacklist it was claimed that the CDC Ethernet support in the adapter > was kinda broken anyway so the blacklist made sense. ...but for the > Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's > just not quite as full featured / efficient as the R8152 driver. > > Is that not a concern? I guess you could tell people in this > situation that they simply need to enable the R8152 driver to get > continued support for their Ethernet adapter? Hi, yes, it is a valid concern. An #ifdef will be needed. Regards Oliver
[toc] | [next] | [standalone]
| From | Grant Grundler <grundler@chromium.org> |
|---|---|
| Date | 2017-09-27 18:40 +0200 |
| Message-ID | <uunxo-5yo-5@gated-at.bofh.it> |
| In reply to | #1740447 |
On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum <oneukum@suse.com> wrote: > Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >> >> I know that for at least some of the adapters in the CDC Ethernet >> blacklist it was claimed that the CDC Ethernet support in the adapter >> was kinda broken anyway so the blacklist made sense. ...but for the >> Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's >> just not quite as full featured / efficient as the R8152 driver. >> >> Is that not a concern? I guess you could tell people in this >> situation that they simply need to enable the R8152 driver to get >> continued support for their Ethernet adapter? > > Hi, > > yes, it is a valid concern. An #ifdef will be needed. Good idea - I will post V3 shortly. I'm assuming you mean to add #ifdef CONFIG_USB_RTL8152 around the blacklist entry in cdc_ether driver. cheers, grant
[toc] | [prev] | [next] | [standalone]
| From | "Rustad, Mark D" <mark.d.rustad@intel.com> |
|---|---|
| Date | 2017-09-29 00:30 +0200 |
| Message-ID | <uuPtD-6ha-1@gated-at.bofh.it> |
| In reply to | #1740876 |
[Multipart message — attachments visible in raw view] — view raw
> On Sep 27, 2017, at 9:39 AM, Grant Grundler <grundler@chromium.org> wrote: > > On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum <oneukum@suse.com> wrote: >> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >>> >>> I know that for at least some of the adapters in the CDC Ethernet >>> blacklist it was claimed that the CDC Ethernet support in the adapter >>> was kinda broken anyway so the blacklist made sense. ...but for the >>> Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's >>> just not quite as full featured / efficient as the R8152 driver. >>> >>> Is that not a concern? I guess you could tell people in this >>> situation that they simply need to enable the R8152 driver to get >>> continued support for their Ethernet adapter? >> >> Hi, >> >> yes, it is a valid concern. An #ifdef will be needed. > > Good idea - I will post V3 shortly. > > I'm assuming you mean to add #ifdef CONFIG_USB_RTL8152 around the > blacklist entry in cdc_ether driver. Shouldn't that be an #if IS_ENABLED(...) test, since that seems to be the proper way to check configured drivers. -- Mark Rustad, Networking Division, Intel Corporation
[toc] | [prev] | [next] | [standalone]
| From | Doug Anderson <dianders@chromium.org> |
|---|---|
| Date | 2017-09-29 02:00 +0200 |
| Message-ID | <uuQSK-70Y-11@gated-at.bofh.it> |
| In reply to | #1741829 |
Hi, On Thu, Sep 28, 2017 at 3:28 PM, Rustad, Mark D <mark.d.rustad@intel.com> wrote: > >> On Sep 27, 2017, at 9:39 AM, Grant Grundler <grundler@chromium.org> wrote: >> >> On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum <oneukum@suse.com> wrote: >>> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >>>> >>>> I know that for at least some of the adapters in the CDC Ethernet >>>> blacklist it was claimed that the CDC Ethernet support in the adapter >>>> was kinda broken anyway so the blacklist made sense. ...but for the >>>> Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's >>>> just not quite as full featured / efficient as the R8152 driver. >>>> >>>> Is that not a concern? I guess you could tell people in this >>>> situation that they simply need to enable the R8152 driver to get >>>> continued support for their Ethernet adapter? >>> >>> Hi, >>> >>> yes, it is a valid concern. An #ifdef will be needed. >> >> Good idea - I will post V3 shortly. >> >> I'm assuming you mean to add #ifdef CONFIG_USB_RTL8152 around the >> blacklist entry in cdc_ether driver. > > Shouldn't that be an #if IS_ENABLED(...) test, since that seems to be the proper way to check configured drivers. Yes, I had the same feedback on v3. See my comments at <https://patchwork.kernel.org/patch/9974485/>. Grant has fixed it in v4. Please see <https://patchwork.kernel.org/patch/9976657/>. :) -Doug
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web