Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1741829
| From | "Rustad, Mark D" <mark.d.rustad@intel.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id |
| Date | 2017-09-29 00:30 +0200 |
| Message-ID | <uuPtD-6ha-1@gated-at.bofh.it> (permalink) |
| References | <utMxP-5WZ-1@gated-at.bofh.it> <utZY5-6wo-17@gated-at.bofh.it> <uueNs-7BL-23@gated-at.bofh.it> <uunxo-5yo-5@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
> On Sep 27, 2017, at 9:39 AM, Grant Grundler <grundler@chromium.org> wrote: > > On Wed, Sep 27, 2017 at 12:15 AM, Oliver Neukum <oneukum@suse.com> wrote: >> Am Dienstag, den 26.09.2017, 08:19 -0700 schrieb Doug Anderson: >>> >>> I know that for at least some of the adapters in the CDC Ethernet >>> blacklist it was claimed that the CDC Ethernet support in the adapter >>> was kinda broken anyway so the blacklist made sense. ...but for the >>> Linksys Gigabit adapter the CDC Ethernet driver seems to work OK, it's >>> just not quite as full featured / efficient as the R8152 driver. >>> >>> Is that not a concern? I guess you could tell people in this >>> situation that they simply need to enable the R8152 driver to get >>> continued support for their Ethernet adapter? >> >> Hi, >> >> yes, it is a valid concern. An #ifdef will be needed. > > Good idea - I will post V3 shortly. > > I'm assuming you mean to add #ifdef CONFIG_USB_RTL8152 around the > blacklist entry in cdc_ether driver. Shouldn't that be an #if IS_ENABLED(...) test, since that seems to be the proper way to check configured drivers. -- Mark Rustad, Networking Division, Intel Corporation
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id Oliver Neukum <oneukum@suse.com> - 2017-09-27 09:20 +0200
Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id Grant Grundler <grundler@chromium.org> - 2017-09-27 18:40 +0200
Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id "Rustad, Mark D" <mark.d.rustad@intel.com> - 2017-09-29 00:30 +0200
Re: [PATCH V2] r8152: add Linksys USB3GIGV1 id Doug Anderson <dianders@chromium.org> - 2017-09-29 02:00 +0200
csiph-web