Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1739619 > unrolled thread
| Started by | changbin.du@intel.com |
|---|---|
| First post | 2017-09-26 09:30 +0200 |
| Last post | 2017-09-27 06:10 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] mm: update comments for struct page.mapping changbin.du@intel.com - 2017-09-26 09:30 +0200
Re: [PATCH] mm: update comments for struct page.mapping Andrew Morton <akpm@linux-foundation.org> - 2017-09-27 01:40 +0200
Re: [PATCH] mm: update comments for struct page.mapping "Du, Changbin" <changbin.du@intel.com> - 2017-09-27 06:10 +0200
| From | changbin.du@intel.com |
|---|---|
| Date | 2017-09-26 09:30 +0200 |
| Subject | [PATCH] mm: update comments for struct page.mapping |
| Message-ID | <utStB-1zD-35@gated-at.bofh.it> |
From: Changbin Du <changbin.du@intel.com>
The struct page.mapping can NULL or points to one object of type
address_space, anon_vma or KSM private structure.
Signed-off-by: Changbin Du <changbin.du@intel.com>
---
include/linux/mm_types.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h
index 46f4ecf5..8dd6cb3 100644
--- a/include/linux/mm_types.h
+++ b/include/linux/mm_types.h
@@ -47,8 +47,8 @@ struct page {
* inode address_space, or NULL.
* If page mapped as anonymous
* memory, low bit is set, and
- * it points to anon_vma object:
- * see PAGE_MAPPING_ANON below.
+ * it points to anon_vma object
+ * or KSM private structure.
*/
void *s_mem; /* slab first object */
atomic_t compound_mapcount; /* first tail page */
--
2.7.4
[toc] | [next] | [standalone]
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Date | 2017-09-27 01:40 +0200 |
| Message-ID | <uu7Ch-2SA-3@gated-at.bofh.it> |
| In reply to | #1739619 |
On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@intel.com wrote:
> From: Changbin Du <changbin.du@intel.com>
>
> The struct page.mapping can NULL or points to one object of type
> address_space, anon_vma or KSM private structure.
>
> ...
>
> --- a/include/linux/mm_types.h
> +++ b/include/linux/mm_types.h
> @@ -47,8 +47,8 @@ struct page {
> * inode address_space, or NULL.
> * If page mapped as anonymous
> * memory, low bit is set, and
> - * it points to anon_vma object:
> - * see PAGE_MAPPING_ANON below.
> + * it points to anon_vma object
> + * or KSM private structure.
> */
> void *s_mem; /* slab first object */
> atomic_t compound_mapcount; /* first tail page */
Why did you remove the (useful) reference to PAGE_MAPPING_ANON?
[toc] | [prev] | [next] | [standalone]
| From | "Du, Changbin" <changbin.du@intel.com> |
|---|---|
| Date | 2017-09-27 06:10 +0200 |
| Message-ID | <uubPA-5LP-3@gated-at.bofh.it> |
| In reply to | #1740281 |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Sep 26, 2017 at 04:30:27PM -0700, Andrew Morton wrote:
> On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@intel.com wrote:
>
> > From: Changbin Du <changbin.du@intel.com>
> >
> > The struct page.mapping can NULL or points to one object of type
> > address_space, anon_vma or KSM private structure.
> >
> > ...
> >
> > --- a/include/linux/mm_types.h
> > +++ b/include/linux/mm_types.h
> > @@ -47,8 +47,8 @@ struct page {
> > * inode address_space, or NULL.
> > * If page mapped as anonymous
> > * memory, low bit is set, and
> > - * it points to anon_vma object:
> > - * see PAGE_MAPPING_ANON below.
> > + * it points to anon_vma object
> > + * or KSM private structure.
> > */
> > void *s_mem; /* slab first object */
> > atomic_t compound_mapcount; /* first tail page */
>
> Why did you remove the (useful) reference to PAGE_MAPPING_ANON?
There are two flags now, let me add them back. thanks.
--
Thanks,
Changbin Du
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web