Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1740378

Re: [PATCH] mm: update comments for struct page.mapping

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, Sep 26, 2017 at 04:30:27PM -0700, Andrew Morton wrote:
> On Tue, 26 Sep 2017 15:14:17 +0800 changbin.du@intel.com wrote:
> 
> > From: Changbin Du <changbin.du@intel.com>
> > 
> > The struct page.mapping can NULL or points to one object of type
> > address_space, anon_vma or KSM private structure.
> > 
> > ...
> >
> > --- a/include/linux/mm_types.h
> > +++ b/include/linux/mm_types.h
> > @@ -47,8 +47,8 @@ struct page {
> >  						 * inode address_space, or NULL.
> >  						 * If page mapped as anonymous
> >  						 * memory, low bit is set, and
> > -						 * it points to anon_vma object:
> > -						 * see PAGE_MAPPING_ANON below.
> > +						 * it points to anon_vma object
> > +						 * or KSM private structure.
> >  						 */
> >  		void *s_mem;			/* slab first object */
> >  		atomic_t compound_mapcount;	/* first tail page */
> 
> Why did you remove the (useful) reference to PAGE_MAPPING_ANON?

There are two flags now, let me add them back. thanks.

-- 
Thanks,
Changbin Du

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] mm: update comments for struct page.mapping changbin.du@intel.com - 2017-09-26 09:30 +0200
  Re: [PATCH] mm: update comments for struct page.mapping Andrew Morton <akpm@linux-foundation.org> - 2017-09-27 01:40 +0200
    Re: [PATCH] mm: update comments for struct page.mapping "Du, Changbin" <changbin.du@intel.com> - 2017-09-27 06:10 +0200

csiph-web