Groups > linux.kernel > #1738806 > unrolled thread

bq27xxx: what is going on with MSLEEP() macro

Started by	Pavel Machek <pavel@ucw.cz>
First post	2017-09-25 10:10 +0200
Last post	2017-09-25 10:10 +0200
Articles	1 — 1 participant

Back to article view | Back to linux.kernel

  bq27xxx: what is going on with MSLEEP() macro Pavel Machek <pavel@ucw.cz> - 2017-09-25 10:10 +0200

#1738806 — bq27xxx: what is going on with MSLEEP() macro

From	Pavel Machek <pavel@ucw.cz>
Date	2017-09-25 10:10 +0200
Subject	bq27xxx: what is going on with MSLEEP() macro
Message-ID	<utwCK-3Gy-5@gated-at.bofh.it>

[Multipart message — attachments visible in raw view] — view raw

Hi!

0670c9b35 drivers/power/supply/bq27xxx_battery.c #define BQ27XXX_MSLEEP(i) usleep_range((i)*1000, (i)*1000+500)

Liam, is this really neccessary? Defining MSLEEP to be USLEEP_RANGE is
quite sneaky and confusing. Plus I don't believe we should be
usleep-ing for 25msec. Can we just replace it with regular msleep?

0670c9b35 drivers/power/supply/bq27xxx_battery.c         /* DO NOT read BQ27XXX_DM_CKSUM
here to verify it! That may cause NVM

Normal kernel style for multi-line comments is

/*
 * foo
 */

Can you fix those?

Thanks,
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[toc] | [standalone]

csiph-web

bq27xxx: what is going on with MSLEEP() macro

Contents

#1738806 — bq27xxx: what is going on with MSLEEP() macro