Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738806
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | bq27xxx: what is going on with MSLEEP() macro |
| Date | 2017-09-25 10:10 +0200 |
| Message-ID | <utwCK-3Gy-5@gated-at.bofh.it> (permalink) |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
Hi! 0670c9b35 drivers/power/supply/bq27xxx_battery.c #define BQ27XXX_MSLEEP(i) usleep_range((i)*1000, (i)*1000+500) Liam, is this really neccessary? Defining MSLEEP to be USLEEP_RANGE is quite sneaky and confusing. Plus I don't believe we should be usleep-ing for 25msec. Can we just replace it with regular msleep? 0670c9b35 drivers/power/supply/bq27xxx_battery.c /* DO NOT read BQ27XXX_DM_CKSUM here to verify it! That may cause NVM Normal kernel style for multi-line comments is /* * foo */ Can you fix those? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
bq27xxx: what is going on with MSLEEP() macro Pavel Machek <pavel@ucw.cz> - 2017-09-25 10:10 +0200
csiph-web