Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738880 > unrolled thread
| Started by | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| First post | 2017-09-25 12:20 +0200 |
| Last post | 2017-09-26 01:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] cpufreq: SPEAr: pr_err() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-25 12:20 +0200
Re: [PATCH] cpufreq: SPEAr: pr_err() strings should end with newlines Viresh Kumar <viresh.kumar@linaro.org> - 2017-09-26 01:20 +0200
| From | Arvind Yadav <arvind.yadav.cs@gmail.com> |
|---|---|
| Date | 2017-09-25 12:20 +0200 |
| Subject | [PATCH] cpufreq: SPEAr: pr_err() strings should end with newlines |
| Message-ID | <utyEx-4YG-1@gated-at.bofh.it> |
pr_err() messages should terminated with a new-line to avoid
other messages being concatenated onto the end.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
---
drivers/cpufreq/spear-cpufreq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c
index 4894924..195f27f 100644
--- a/drivers/cpufreq/spear-cpufreq.c
+++ b/drivers/cpufreq/spear-cpufreq.c
@@ -177,7 +177,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev)
np = of_cpu_device_node_get(0);
if (!np) {
- pr_err("No cpu node found");
+ pr_err("No cpu node found\n");
return -ENODEV;
}
@@ -187,7 +187,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev)
prop = of_find_property(np, "cpufreq_tbl", NULL);
if (!prop || !prop->value) {
- pr_err("Invalid cpufreq_tbl");
+ pr_err("Invalid cpufreq_tbl\n");
ret = -ENODEV;
goto out_put_node;
}
--
1.9.1
[toc] | [next] | [standalone]
| From | Viresh Kumar <viresh.kumar@linaro.org> |
|---|---|
| Date | 2017-09-26 01:20 +0200 |
| Message-ID | <utKPo-4Lc-1@gated-at.bofh.it> |
| In reply to | #1738880 |
On 25-09-17, 15:43, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
> drivers/cpufreq/spear-cpufreq.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c
> index 4894924..195f27f 100644
> --- a/drivers/cpufreq/spear-cpufreq.c
> +++ b/drivers/cpufreq/spear-cpufreq.c
> @@ -177,7 +177,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev)
>
> np = of_cpu_device_node_get(0);
> if (!np) {
> - pr_err("No cpu node found");
> + pr_err("No cpu node found\n");
> return -ENODEV;
> }
>
> @@ -187,7 +187,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev)
>
> prop = of_find_property(np, "cpufreq_tbl", NULL);
> if (!prop || !prop->value) {
> - pr_err("Invalid cpufreq_tbl");
> + pr_err("Invalid cpufreq_tbl\n");
> ret = -ENODEV;
> goto out_put_node;
> }
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web