Re: [PATCH] cpufreq: SPEAr: pr_err() strings should end with newlines

From	Viresh Kumar <viresh.kumar@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] cpufreq: SPEAr: pr_err() strings should end with newlines
Date	2017-09-26 01:20 +0200
Message-ID	<utKPo-4Lc-1@gated-at.bofh.it> (permalink)
References	<utyEx-4YG-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 25-09-17, 15:43, Arvind Yadav wrote:
> pr_err() messages should terminated with a new-line to avoid
> other messages being concatenated onto the end.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/cpufreq/spear-cpufreq.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/cpufreq/spear-cpufreq.c b/drivers/cpufreq/spear-cpufreq.c
> index 4894924..195f27f 100644
> --- a/drivers/cpufreq/spear-cpufreq.c
> +++ b/drivers/cpufreq/spear-cpufreq.c
> @@ -177,7 +177,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev)
>  
>  	np = of_cpu_device_node_get(0);
>  	if (!np) {
> -		pr_err("No cpu node found");
> +		pr_err("No cpu node found\n");
>  		return -ENODEV;
>  	}
>  
> @@ -187,7 +187,7 @@ static int spear_cpufreq_probe(struct platform_device *pdev)
>  
>  	prop = of_find_property(np, "cpufreq_tbl", NULL);
>  	if (!prop || !prop->value) {
> -		pr_err("Invalid cpufreq_tbl");
> +		pr_err("Invalid cpufreq_tbl\n");
>  		ret = -ENODEV;
>  		goto out_put_node;
>  	}

Acked-by: Viresh Kumar <viresh.kumar@linaro.org>

-- 
viresh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] cpufreq: SPEAr: pr_err() strings should end with newlines Arvind Yadav <arvind.yadav.cs@gmail.com> - 2017-09-25 12:20 +0200
  Re: [PATCH] cpufreq: SPEAr: pr_err() strings should end with newlines Viresh Kumar <viresh.kumar@linaro.org> - 2017-09-26 01:20 +0200

csiph-web