Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1738067 > unrolled thread
| Started by | Pavel Machek <pavel@ucw.cz> |
|---|---|
| First post | 2017-09-23 22:20 +0200 |
| Last post | 2017-09-24 10:30 +0200 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Pavel Machek <pavel@ucw.cz> - 2017-09-23 22:20 +0200
Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Marek Vasut <marek.vasut@gmail.com> - 2017-09-23 23:20 +0200
Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Richard Weinberger <richard@nod.at> - 2017-09-24 10:30 +0200
Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-24 10:30 +0200
| From | Pavel Machek <pavel@ucw.cz> |
|---|---|
| Date | 2017-09-23 22:20 +0200 |
| Subject | [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h |
| Message-ID | <usZ46-7GJ-5@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
C++ comments look wrong in kernel tree. Fix one.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
index 6cd0f6b..849543f1 100644
--- a/include/linux/mtd/mtd.h
+++ b/include/linux/mtd/mtd.h
@@ -267,7 +267,7 @@ struct mtd_info {
*/
unsigned int bitflip_threshold;
- // Kernel-only stuff starts here.
+ /* Kernel-only stuff starts here. */
const char *name;
int index;
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
[toc] | [next] | [standalone]
| From | Marek Vasut <marek.vasut@gmail.com> |
|---|---|
| Date | 2017-09-23 23:20 +0200 |
| Message-ID | <ut009-8kS-1@gated-at.bofh.it> |
| In reply to | #1738067 |
On 09/23/2017 10:13 PM, Pavel Machek wrote:
> C++ comments look wrong in kernel tree. Fix one.
AFAIR they are now (sadly) accepted, but this patch works for me.
Would be nice if trivial could pick it.
> Signed-off-by: Pavel Machek <pavel@ucw.cz>
>
> diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> index 6cd0f6b..849543f1 100644
> --- a/include/linux/mtd/mtd.h
> +++ b/include/linux/mtd/mtd.h
> @@ -267,7 +267,7 @@ struct mtd_info {
> */
> unsigned int bitflip_threshold;
>
> - // Kernel-only stuff starts here.
> + /* Kernel-only stuff starts here. */
> const char *name;
> int index;
>
>
--
Best regards,
Marek Vasut
[toc] | [prev] | [next] | [standalone]
| From | Richard Weinberger <richard@nod.at> |
|---|---|
| Date | 2017-09-24 10:30 +0200 |
| Message-ID | <utasy-6nG-5@gated-at.bofh.it> |
| In reply to | #1738078 |
Am Sonntag, 24. September 2017, 10:20:06 CEST schrieb Boris Brezillon: > On Sat, 23 Sep 2017 23:10:26 +0200 > > Marek Vasut <marek.vasut@gmail.com> wrote: > > On 09/23/2017 10:13 PM, Pavel Machek wrote: > > > C++ comments look wrong in kernel tree. Fix one. > > > > AFAIR they are now (sadly) accepted, but this patch works for me. > > Works for me too. Here is my > > Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com> > > > Would be nice if trivial could pick it. > > Hm, I'd recommend not doing that, otherwise we might end up with a > conflict if a patch modify something in this area. Let's carry it via MTD. BTW: Shouldn't it be s/kernel/comment/ in the subject line? Thanks, //richard
[toc] | [prev] | [next] | [standalone]
| From | Boris Brezillon <boris.brezillon@free-electrons.com> |
|---|---|
| Date | 2017-09-24 10:30 +0200 |
| Message-ID | <utasy-6nG-7@gated-at.bofh.it> |
| In reply to | #1738078 |
On Sat, 23 Sep 2017 23:10:26 +0200
Marek Vasut <marek.vasut@gmail.com> wrote:
> On 09/23/2017 10:13 PM, Pavel Machek wrote:
> > C++ comments look wrong in kernel tree. Fix one.
>
> AFAIR they are now (sadly) accepted, but this patch works for me.
Works for me too. Here is my
Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>
> Would be nice if trivial could pick it.
Hm, I'd recommend not doing that, otherwise we might end up with a
conflict if a patch modify something in this area.
>
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> >
> > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> > index 6cd0f6b..849543f1 100644
> > --- a/include/linux/mtd/mtd.h
> > +++ b/include/linux/mtd/mtd.h
> > @@ -267,7 +267,7 @@ struct mtd_info {
> > */
> > unsigned int bitflip_threshold;
> >
> > - // Kernel-only stuff starts here.
> > + /* Kernel-only stuff starts here. */
> > const char *name;
> > int index;
> >
> >
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web