Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h

From	Boris Brezillon <boris.brezillon@free-electrons.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h
Date	2017-09-24 10:30 +0200
Message-ID	<utasy-6nG-7@gated-at.bofh.it> (permalink)
References	<usZ46-7GJ-5@gated-at.bofh.it> <ut009-8kS-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, 23 Sep 2017 23:10:26 +0200
Marek Vasut <marek.vasut@gmail.com> wrote:

> On 09/23/2017 10:13 PM, Pavel Machek wrote:
> > C++ comments look wrong in kernel tree. Fix one.  
> 
> AFAIR they are now (sadly) accepted, but this patch works for me.

Works for me too. Here is my

Acked-by: Boris Brezillon <boris.brezillon@free-electrons.com>

> Would be nice if trivial could pick it.

Hm, I'd recommend not doing that, otherwise we might end up with a
conflict if a patch modify something in this area.

> 
> > Signed-off-by: Pavel Machek <pavel@ucw.cz>
> > 
> > diff --git a/include/linux/mtd/mtd.h b/include/linux/mtd/mtd.h
> > index 6cd0f6b..849543f1 100644
> > --- a/include/linux/mtd/mtd.h
> > +++ b/include/linux/mtd/mtd.h
> > @@ -267,7 +267,7 @@ struct mtd_info {
> >  	 */
> >  	unsigned int bitflip_threshold;
> >  
> > -	// Kernel-only stuff starts here.
> > +	/* Kernel-only stuff starts here. */
> >  	const char *name;
> >  	int index;
> >  
> >   
> 
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Pavel Machek <pavel@ucw.cz> - 2017-09-23 22:20 +0200
  Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Marek Vasut <marek.vasut@gmail.com> - 2017-09-23 23:20 +0200
    Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Richard Weinberger <richard@nod.at> - 2017-09-24 10:30 +0200
    Re: [PATCH] Fix C++ kernel in include/linux/mtd/mtd.h Boris Brezillon <boris.brezillon@free-electrons.com> - 2017-09-24 10:30 +0200

csiph-web