Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1737245 > unrolled thread

[PATCH] Input: stmfts - use devm_device_add_group

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH] Input: stmfts - use devm_device_add_group Andi Shyti <andi.shyti@samsung.com> - 2017-09-22 10:00 +0200
    Re: [PATCH] Input: stmfts - use devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-22 19:10 +0200

#1737245 — [PATCH] Input: stmfts - use devm_device_add_group

instead of sysfs_create_group.

Signed-off-by: Andi Shyti <andi.shyti@samsung.com>
---
 drivers/input/touchscreen/stmfts.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
index 157fdb4bb2e8..2351199189a4 100644
--- a/drivers/input/touchscreen/stmfts.c
+++ b/drivers/input/touchscreen/stmfts.c
@@ -727,8 +727,7 @@ static int stmfts_probe(struct i2c_client *client,
 		}
 	}
 
-	err = sysfs_create_group(&sdata->client->dev.kobj,
-				 &stmfts_attribute_group);
+	err = devm_device_add_group(&client->dev, &stmfts_attribute_group);
 	if (err)
 		return err;
 
@@ -740,7 +739,6 @@ static int stmfts_probe(struct i2c_client *client,
 static int stmfts_remove(struct i2c_client *client)
 {
 	pm_runtime_disable(&client->dev);
-	sysfs_remove_group(&client->dev.kobj, &stmfts_attribute_group);
 
 	return 0;
 }
-- 
2.14.1

[toc] | [next] | [standalone]

#1737698

On Fri, Sep 22, 2017 at 04:52:38PM +0900, Andi Shyti wrote:
> instead of sysfs_create_group.
> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/stmfts.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
> index 157fdb4bb2e8..2351199189a4 100644
> --- a/drivers/input/touchscreen/stmfts.c
> +++ b/drivers/input/touchscreen/stmfts.c
> @@ -727,8 +727,7 @@ static int stmfts_probe(struct i2c_client *client,
>  		}
>  	}
>  
> -	err = sysfs_create_group(&sdata->client->dev.kobj,
> -				 &stmfts_attribute_group);
> +	err = devm_device_add_group(&client->dev, &stmfts_attribute_group);
>  	if (err)
>  		return err;
>  
> @@ -740,7 +739,6 @@ static int stmfts_probe(struct i2c_client *client,
>  static int stmfts_remove(struct i2c_client *client)
>  {
>  	pm_runtime_disable(&client->dev);
> -	sysfs_remove_group(&client->dev.kobj, &stmfts_attribute_group);
>  
>  	return 0;
>  }
> -- 
> 2.14.1
> 

-- 
Dmitry

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web