Re: [PATCH] Input: stmfts - use devm_device_add_group

From	Dmitry Torokhov <dmitry.torokhov@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] Input: stmfts - use devm_device_add_group
Date	2017-09-22 19:10 +0200
Message-ID	<uszCG-kW-11@gated-at.bofh.it> (permalink)
References	<usr2p-3rE-15@gated-at.bofh.it> <usr2p-3rE-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, Sep 22, 2017 at 04:52:38PM +0900, Andi Shyti wrote:
> instead of sysfs_create_group.
> 
> Signed-off-by: Andi Shyti <andi.shyti@samsung.com>

Applied, thank you.

> ---
>  drivers/input/touchscreen/stmfts.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/input/touchscreen/stmfts.c b/drivers/input/touchscreen/stmfts.c
> index 157fdb4bb2e8..2351199189a4 100644
> --- a/drivers/input/touchscreen/stmfts.c
> +++ b/drivers/input/touchscreen/stmfts.c
> @@ -727,8 +727,7 @@ static int stmfts_probe(struct i2c_client *client,
>  		}
>  	}
>  
> -	err = sysfs_create_group(&sdata->client->dev.kobj,
> -				 &stmfts_attribute_group);
> +	err = devm_device_add_group(&client->dev, &stmfts_attribute_group);
>  	if (err)
>  		return err;
>  
> @@ -740,7 +739,6 @@ static int stmfts_probe(struct i2c_client *client,
>  static int stmfts_remove(struct i2c_client *client)
>  {
>  	pm_runtime_disable(&client->dev);
> -	sysfs_remove_group(&client->dev.kobj, &stmfts_attribute_group);
>  
>  	return 0;
>  }
> -- 
> 2.14.1
> 

-- 
Dmitry

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] Input: stmfts - use devm_device_add_group Andi Shyti <andi.shyti@samsung.com> - 2017-09-22 10:00 +0200
  Re: [PATCH] Input: stmfts - use devm_device_add_group Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-22 19:10 +0200

csiph-web