Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1737212 > unrolled thread
| Started by | Jason Wang <jasowang@redhat.com> |
|---|---|
| First post | 2017-09-22 08:40 +0200 |
| Last post | 2017-09-23 03:20 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH net-next] virtio-net: correctly set xdp_xmit for mergeable buffer Jason Wang <jasowang@redhat.com> - 2017-09-22 08:40 +0200
Re: [PATCH net-next] virtio-net: correctly set xdp_xmit for mergeable buffer David Miller <davem@davemloft.net> - 2017-09-23 03:20 +0200
| From | Jason Wang <jasowang@redhat.com> |
|---|---|
| Date | 2017-09-22 08:40 +0200 |
| Subject | [PATCH net-next] virtio-net: correctly set xdp_xmit for mergeable buffer |
| Message-ID | <uspN0-2MQ-19@gated-at.bofh.it> |
We should set xdp_xmit only when xdp_do_redirect() succeed. Cc: John Fastabend <john.fastabend@gmail.com> Signed-off-by: Jason Wang <jasowang@redhat.com> --- drivers/net/virtio_net.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c index f6c1f13..dd14a45 100644 --- a/drivers/net/virtio_net.c +++ b/drivers/net/virtio_net.c @@ -721,7 +721,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev, goto xdp_xmit; case XDP_REDIRECT: err = xdp_do_redirect(dev, &xdp, xdp_prog); - if (err) + if (!err) *xdp_xmit = true; rcu_read_unlock(); goto xdp_xmit; -- 2.7.4
[toc] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2017-09-23 03:20 +0200 |
| Subject | Re: [PATCH net-next] virtio-net: correctly set xdp_xmit for mergeable buffer |
| Message-ID | <usHgS-4Zr-3@gated-at.bofh.it> |
| In reply to | #1737212 |
From: Jason Wang <jasowang@redhat.com> Date: Fri, 22 Sep 2017 14:38:58 +0800 > We should set xdp_xmit only when xdp_do_redirect() succeed. > > Cc: John Fastabend <john.fastabend@gmail.com> > Signed-off-by: Jason Wang <jasowang@redhat.com> Applied, thanks Jason.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web