[PATCH net-next] virtio-net: correctly set xdp_xmit for mergeable buffer

From	Jason Wang <jasowang@redhat.com>
Newsgroups	linux.kernel
Subject	[PATCH net-next] virtio-net: correctly set xdp_xmit for mergeable buffer
Date	2017-09-22 08:40 +0200
Message-ID	<uspN0-2MQ-19@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

We should set xdp_xmit only when xdp_do_redirect() succeed.

Cc: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
---
 drivers/net/virtio_net.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
index f6c1f13..dd14a45 100644
--- a/drivers/net/virtio_net.c
+++ b/drivers/net/virtio_net.c
@@ -721,7 +721,7 @@ static struct sk_buff *receive_mergeable(struct net_device *dev,
 			goto xdp_xmit;
 		case XDP_REDIRECT:
 			err = xdp_do_redirect(dev, &xdp, xdp_prog);
-			if (err)
+			if (!err)
 				*xdp_xmit = true;
 			rcu_read_unlock();
 			goto xdp_xmit;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH net-next] virtio-net: correctly set xdp_xmit for mergeable buffer Jason Wang <jasowang@redhat.com> - 2017-09-22 08:40 +0200
  Re: [PATCH net-next] virtio-net: correctly set xdp_xmit for  mergeable buffer David Miller <davem@davemloft.net> - 2017-09-23 03:20 +0200

csiph-web