Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1736302 > unrolled thread
| Started by | Chris Packham <chris.packham@alliedtelesis.co.nz> |
|---|---|
| First post | 2017-09-21 03:00 +0200 |
| Last post | 2017-09-21 17:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
[PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-09-21 03:00 +0200
Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-09-21 10:00 +0200
Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-09-21 17:50 +0200
| From | Chris Packham <chris.packham@alliedtelesis.co.nz> |
|---|---|
| Date | 2017-09-21 03:00 +0200 |
| Subject | [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq |
| Message-ID | <urY0p-21a-5@gated-at.bofh.it> |
Add a default compatible string "linux,uio-pdrv-genirq" to
uio_pdrv_genirq to make it usable without supplying a module parameter.
The module parameter is still supported in addition to the default.
Signed-off-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
---
drivers/uio/uio_pdrv_genirq.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/uio/uio_pdrv_genirq.c b/drivers/uio/uio_pdrv_genirq.c
index f598ecddc8a7..8dd4729e14ab 100644
--- a/drivers/uio/uio_pdrv_genirq.c
+++ b/drivers/uio/uio_pdrv_genirq.c
@@ -253,11 +253,12 @@ static const struct dev_pm_ops uio_pdrv_genirq_dev_pm_ops = {
#ifdef CONFIG_OF
static struct of_device_id uio_of_genirq_match[] = {
+ { .compatible = "linux,uio-pdrv-genirq" },
{ /* This is filled with module_parm */ },
{ /* Sentinel */ },
};
MODULE_DEVICE_TABLE(of, uio_of_genirq_match);
-module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
+module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000);
MODULE_PARM_DESC(of_id, "Openfirmware id of the device to be handled by uio");
#endif
--
2.14.1
[toc] | [next] | [standalone]
| From | Andy Shevchenko <andy.shevchenko@gmail.com> |
|---|---|
| Date | 2017-09-21 10:00 +0200 |
| Message-ID | <us4yR-6pb-3@gated-at.bofh.it> |
| In reply to | #1736302 |
On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham <chris.packham@alliedtelesis.co.nz> wrote: > -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0); > +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000); 0 -> 0000 looks like bogus checkpatch warning. -- With Best Regards, Andy Shevchenko
[toc] | [prev] | [next] | [standalone]
| From | Chris Packham <Chris.Packham@alliedtelesis.co.nz> |
|---|---|
| Date | 2017-09-21 17:50 +0200 |
| Message-ID | <usbTI-2TP-25@gated-at.bofh.it> |
| In reply to | #1736431 |
On 21/09/17 19:50, Andy Shevchenko wrote: > On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham > <chris.packham@alliedtelesis.co.nz> wrote: > > >> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0); >> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000); > > 0 -> 0000 looks like bogus checkpatch warning. > Yes. I changed it to satisfy checkpatch. I initially wasn't going to but then I noticed plenty of 0000 attached to module_params. I'll switch it back in v2.
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web