Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq

From	Chris Packham <Chris.Packham@alliedtelesis.co.nz>
Newsgroups	linux.kernel
Subject	Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq
Date	2017-09-21 17:50 +0200
Message-ID	<usbTI-2TP-25@gated-at.bofh.it> (permalink)
References	<urY0p-21a-3@gated-at.bofh.it> <urY0p-21a-5@gated-at.bofh.it> <us4yR-6pb-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 21/09/17 19:50, Andy Shevchenko wrote:
> On Thu, Sep 21, 2017 at 3:53 AM, Chris Packham
> <chris.packham@alliedtelesis.co.nz> wrote:
> 
> 
>> -module_param_string(of_id, uio_of_genirq_match[0].compatible, 128, 0);
>> +module_param_string(of_id, uio_of_genirq_match[1].compatible, 128, 0000);
> 
> 0 -> 0000 looks like bogus checkpatch warning.
> 

Yes. I changed it to satisfy checkpatch. I initially wasn't going to but 
then I noticed plenty of 0000 attached to module_params. I'll switch it 
back in v2.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq Chris Packham <chris.packham@alliedtelesis.co.nz> - 2017-09-21 03:00 +0200
  Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq Andy Shevchenko <andy.shevchenko@gmail.com> - 2017-09-21 10:00 +0200
    Re: [PATCH 2/2] uio: add default compatible string to uio_pdrv_genirq Chris Packham <Chris.Packham@alliedtelesis.co.nz> - 2017-09-21 17:50 +0200

csiph-web