Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1733420 > unrolled thread

[PATCH 0/2] [media] AirSpy: Adjustments for airspy_probe()

Back to article view | Back to linux.kernel

Contents

  [PATCH 0/2] [media] AirSpy: Adjustments for airspy_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 11:20 +0200
    [PATCH 1/2] [media] airspy: Delete an error message for a failed  memory allocation in airspy_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 11:20 +0200
    [PATCH 2/2] [media] airspy: Improve a size determination in  airspy_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 11:30 +0200

#1733420 — [PATCH 0/2] [media] AirSpy: Adjustments for airspy_probe()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 17 Sep 2017 11:11:02 +0200

Two update suggestions were taken into account
from static source code analysis.

Markus Elfring (2):
  Delete an error message for a failed memory allocation
  Improve a size determination

 drivers/media/usb/airspy/airspy.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

-- 
2.14.1

[toc] | [next] | [standalone]

#1733421 — [PATCH 1/2] [media] airspy: Delete an error message for a failed memory allocation in airspy_probe()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 17 Sep 2017 11:00:09 +0200

Omit an extra message for a memory allocation failure in this function.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/usb/airspy/airspy.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/usb/airspy/airspy.c b/drivers/media/usb/airspy/airspy.c
index e70c9e2f3798..72b36dbcc0ba 100644
--- a/drivers/media/usb/airspy/airspy.c
+++ b/drivers/media/usb/airspy/airspy.c
@@ -985,7 +985,5 @@ static int airspy_probe(struct usb_interface *intf,
-	if (s == NULL) {
-		dev_err(&intf->dev, "Could not allocate memory for state\n");
+	if (!s)
 		return -ENOMEM;
-	}
 
 	mutex_init(&s->v4l2_lock);
 	mutex_init(&s->vb_queue_lock);
-- 
2.14.1

[toc] | [prev] | [next] | [standalone]

#1733422 — [PATCH 2/2] [media] airspy: Improve a size determination in airspy_probe()

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 17 Sep 2017 11:03:21 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/usb/airspy/airspy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/airspy/airspy.c b/drivers/media/usb/airspy/airspy.c
index 72b36dbcc0ba..5810c05f6300 100644
--- a/drivers/media/usb/airspy/airspy.c
+++ b/drivers/media/usb/airspy/airspy.c
@@ -981,5 +981,5 @@ static int airspy_probe(struct usb_interface *intf,
 	int ret;
 	u8 u8tmp, buf[BUF_SIZE];
 
-	s = kzalloc(sizeof(struct airspy), GFP_KERNEL);
+	s = kzalloc(sizeof(*s), GFP_KERNEL);
 	if (!s)
-- 
2.14.1

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web