[PATCH 2/2] [media] airspy: Improve a size determination in airspy_probe()

From	SF Markus Elfring <elfring@users.sourceforge.net>
Newsgroups	linux.kernel
Subject	[PATCH 2/2] [media] airspy: Improve a size determination in airspy_probe()
Date	2017-09-17 11:30 +0200
Message-ID	<uqE3L-62M-11@gated-at.bofh.it> (permalink)
References	<uqDU6-5Zo-11@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Markus Elfring <elfring@users.sourceforge.net>
Date: Sun, 17 Sep 2017 11:03:21 +0200

Replace the specification of a data structure by a pointer dereference
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
 drivers/media/usb/airspy/airspy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/usb/airspy/airspy.c b/drivers/media/usb/airspy/airspy.c
index 72b36dbcc0ba..5810c05f6300 100644
--- a/drivers/media/usb/airspy/airspy.c
+++ b/drivers/media/usb/airspy/airspy.c
@@ -981,5 +981,5 @@ static int airspy_probe(struct usb_interface *intf,
 	int ret;
 	u8 u8tmp, buf[BUF_SIZE];
 
-	s = kzalloc(sizeof(struct airspy), GFP_KERNEL);
+	s = kzalloc(sizeof(*s), GFP_KERNEL);
 	if (!s)
-- 
2.14.1

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] [media] AirSpy: Adjustments for airspy_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 11:20 +0200
  [PATCH 1/2] [media] airspy: Delete an error message for a failed  memory allocation in airspy_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 11:20 +0200
  [PATCH 2/2] [media] airspy: Improve a size determination in  airspy_probe() SF Markus Elfring <elfring@users.sourceforge.net> - 2017-09-17 11:30 +0200

csiph-web