Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1730993 > unrolled thread
| Started by | Josh Poimboeuf <jpoimboe@redhat.com> |
|---|---|
| First post | 2017-09-12 18:30 +0200 |
| Last post | 2017-09-13 15:50 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v6] livepatch: introduce shadow variable API Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-12 18:30 +0200
Re: [PATCH v6] livepatch: introduce shadow variable API Joe Lawrence <joe.lawrence@redhat.com> - 2017-09-13 00:20 +0200
Re: [PATCH v6] livepatch: introduce shadow variable API Jiri Kosina <jikos@kernel.org> - 2017-09-13 15:50 +0200
| From | Josh Poimboeuf <jpoimboe@redhat.com> |
|---|---|
| Date | 2017-09-12 18:30 +0200 |
| Subject | Re: [PATCH v6] livepatch: introduce shadow variable API |
| Message-ID | <uoWet-3Az-11@gated-at.bofh.it> |
On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote:
> +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> + size_t size, gfp_t gfp_flags, bool warn_on_exist)
> +{
> + struct klp_shadow *new_shadow;
> + void *shadow_data;
> + unsigned long flags;
> +
> + /* Check if the shadow variable if <obj, id> already exists */
Grammar fix: either
s/if the shadow variable//
or
s/if <obj, id>//
Otherwise:
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
[toc] | [next] | [standalone]
| From | Joe Lawrence <joe.lawrence@redhat.com> |
|---|---|
| Date | 2017-09-13 00:20 +0200 |
| Message-ID | <up1Hc-7bb-5@gated-at.bofh.it> |
| In reply to | #1730993 |
On 09/12/2017 12:20 PM, Josh Poimboeuf wrote:
> On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote:
>> +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
>> + size_t size, gfp_t gfp_flags, bool warn_on_exist)
>> +{
>> + struct klp_shadow *new_shadow;
>> + void *shadow_data;
>> + unsigned long flags;
>> +
>> + /* Check if the shadow variable if <obj, id> already exists */
>
> Grammar fix: either
>
> s/if the shadow variable//
>
> or
>
> s/if <obj, id>//
>
> Otherwise:
>
> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
>
If this is the only outstanding nit, can this be fixed up on merge or
does it need a new patch spin?
Thanks,
-- Joe
[toc] | [prev] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2017-09-13 15:50 +0200 |
| Message-ID | <upgdb-834-5@gated-at.bofh.it> |
| In reply to | #1731264 |
On Tue, 12 Sep 2017, Joe Lawrence wrote:
> > On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote:
> >> +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> >> + size_t size, gfp_t gfp_flags, bool warn_on_exist)
> >> +{
> >> + struct klp_shadow *new_shadow;
> >> + void *shadow_data;
> >> + unsigned long flags;
> >> +
> >> + /* Check if the shadow variable if <obj, id> already exists */
> >
> > Grammar fix: either
> >
> > s/if the shadow variable//
> >
> > or
> >
> > s/if <obj, id>//
> >
> > Otherwise:
> >
> > Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
> >
>
> If this is the only outstanding nit, can this be fixed up on merge or
> does it need a new patch spin?
No need to resend just because of this, I'll fix this up manually once
applying.
Thanks,
--
Jiri Kosina
SUSE Labs
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web