Re: [PATCH v6] livepatch: introduce shadow variable API

From	Josh Poimboeuf <jpoimboe@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v6] livepatch: introduce shadow variable API
Date	2017-09-12 18:30 +0200
Message-ID	<uoWet-3Az-11@gated-at.bofh.it> (permalink)
References	<ukEpP-24O-7@gated-at.bofh.it> <ukEpP-24O-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Aug 31, 2017 at 04:37:41PM -0400, Joe Lawrence wrote:
> +void *__klp_shadow_get_or_alloc(void *obj, unsigned long id, void *data,
> +		       size_t size, gfp_t gfp_flags, bool warn_on_exist)
> +{
> +	struct klp_shadow *new_shadow;
> +	void *shadow_data;
> +	unsigned long flags;
> +
> +	/* Check if the shadow variable if <obj, id> already exists */

Grammar fix: either

  s/if the shadow variable//

or

  s/if <obj, id>//

Otherwise:

Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>

-- 
Josh

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6] livepatch: introduce shadow variable API Josh Poimboeuf <jpoimboe@redhat.com> - 2017-09-12 18:30 +0200
  Re: [PATCH v6] livepatch: introduce shadow variable API Joe Lawrence <joe.lawrence@redhat.com> - 2017-09-13 00:20 +0200
    Re: [PATCH v6] livepatch: introduce shadow variable API Jiri Kosina <jikos@kernel.org> - 2017-09-13 15:50 +0200

csiph-web