Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1729459 > unrolled thread

Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON Greg KH <gregkh@linuxfoundation.org> - 2017-09-09 16:20 +0200

#1729459 — Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON

On Sat, Sep 09, 2017 at 06:59:42PM +0530, Pintu Kumar wrote:
> This patch is the fix for the below checkpatch issue:
> CHECK: Avoid crashing the kernel - try using WARN_ON &
> recovery code rather than BUG() or BUG_ON()
> +	BUG();
> 
> Ideally this condition should never occur. But even if occurs
> there is no point in crashing the whole kernel.
> Just a warning should be enough to find the issue.

Nope, see the archives for when this has been rejected in the past.

You can't just trivially replace BUG with WARN, otherwise it would have
been done already :)

sorry,

greg k-h

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web