Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1729459
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON |
| Date | 2017-09-09 16:20 +0200 |
| Message-ID | <unOM2-6wA-13@gated-at.bofh.it> (permalink) |
| References | <unOM2-6wA-15@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Sat, Sep 09, 2017 at 06:59:42PM +0530, Pintu Kumar wrote: > This patch is the fix for the below checkpatch issue: > CHECK: Avoid crashing the kernel - try using WARN_ON & > recovery code rather than BUG() or BUG_ON() > + BUG(); > > Ideally this condition should never occur. But even if occurs > there is no point in crashing the whole kernel. > Just a warning should be enough to find the issue. Nope, see the archives for when this has been rejected in the past. You can't just trivially replace BUG with WARN, otherwise it would have been done already :) sorry, greg k-h
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH 1/1] [staging]: android:ion: replace BUG with WARN_ON Greg KH <gregkh@linuxfoundation.org> - 2017-09-09 16:20 +0200
csiph-web