Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1727981 > unrolled thread
| Started by | Srishti Sharma <srishtishar@gmail.com> |
|---|---|
| First post | 2017-09-07 09:50 +0200 |
| Last post | 2017-09-07 12:00 +0200 |
| Articles | 5 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH v5] Staging: ccree: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-07 09:50 +0200
Re: [PATCH v5] Staging: ccree: Remove unused variable. Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-07 10:00 +0200
Re: [Outreachy kernel] [PATCH v5] Staging: ccree: Remove unused variable. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-07 10:30 +0200
Re: [PATCH v5] Staging: ccree: Remove unused variable. Gilad Ben-Yossef <gilad@benyossef.com> - 2017-09-07 11:00 +0200
Re: [PATCH v5] Staging: ccree: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-07 12:00 +0200
| From | Srishti Sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-09-07 09:50 +0200 |
| Subject | [PATCH v5] Staging: ccree: Remove unused variable. |
| Message-ID | <umZJw-5lZ-1@gated-at.bofh.it> |
Remove the local variable inflight_counter as it is never used.
Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
---
Changes in v5:
- Correct the format of the subject.
drivers/staging/ccree/ssi_cipher.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
index 8d31a93..1ff3c8a 100644
--- a/drivers/staging/ccree/ssi_cipher.c
+++ b/drivers/staging/ccree/ssi_cipher.c
@@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
void __iomem *cc_base)
{
int completion_error = 0;
- u32 inflight_counter;
struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
- /*Set the inflight couter value to local variable*/
- inflight_counter = ctx_p->drvdata->inflight_counter;
/*Decrease the inflight counter*/
if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
ctx_p->drvdata->inflight_counter--;
--
2.7.4
[toc] | [next] | [standalone]
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2017-09-07 10:00 +0200 |
| Message-ID | <umZTd-5qV-29@gated-at.bofh.it> |
| In reply to | #1727981 |
Looks good. Thanks! regards, dan carpenter
[toc] | [prev] | [next] | [standalone]
| From | Julia Lawall <julia.lawall@lip6.fr> |
|---|---|
| Date | 2017-09-07 10:30 +0200 |
| Subject | Re: [Outreachy kernel] [PATCH v5] Staging: ccree: Remove unused variable. |
| Message-ID | <un0md-5Sg-1@gated-at.bofh.it> |
| In reply to | #1727981 |
On Thu, 7 Sep 2017, Srishti Sharma wrote:
> Remove the local variable inflight_counter as it is never used.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
Acked-by: Julia Lawall <julia.lawall@lip6.fr>
> ---
> Changes in v5:
> - Correct the format of the subject.
> drivers/staging/ccree/ssi_cipher.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
> index 8d31a93..1ff3c8a 100644
> --- a/drivers/staging/ccree/ssi_cipher.c
> +++ b/drivers/staging/ccree/ssi_cipher.c
> @@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
> void __iomem *cc_base)
> {
> int completion_error = 0;
> - u32 inflight_counter;
> struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
>
> ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>
> - /*Set the inflight couter value to local variable*/
> - inflight_counter = ctx_p->drvdata->inflight_counter;
> /*Decrease the inflight counter*/
> if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
> ctx_p->drvdata->inflight_counter--;
> --
> 2.7.4
>
> --
> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
> To post to this group, send email to outreachy-kernel@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/1504770561-5554-1-git-send-email-srishtishar%40gmail.com.
> For more options, visit https://groups.google.com/d/optout.
>
[toc] | [prev] | [next] | [standalone]
| From | Gilad Ben-Yossef <gilad@benyossef.com> |
|---|---|
| Date | 2017-09-07 11:00 +0200 |
| Message-ID | <un0Pf-61N-11@gated-at.bofh.it> |
| In reply to | #1727981 |
Hi,
On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma <srishtishar@gmail.com> wrote:
> Remove the local variable inflight_counter as it is never used.
>
> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
> ---
I've been meaning to clean that for some time now and never got around to do it.
Thank you! :-)
Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
> Changes in v5:
> - Correct the format of the subject.
> drivers/staging/ccree/ssi_cipher.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
> index 8d31a93..1ff3c8a 100644
> --- a/drivers/staging/ccree/ssi_cipher.c
> +++ b/drivers/staging/ccree/ssi_cipher.c
> @@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
> void __iomem *cc_base)
> {
> int completion_error = 0;
> - u32 inflight_counter;
> struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
>
> ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>
> - /*Set the inflight couter value to local variable*/
> - inflight_counter = ctx_p->drvdata->inflight_counter;
> /*Decrease the inflight counter*/
> if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
> ctx_p->drvdata->inflight_counter--;
> --
> 2.7.4
>
--
Gilad Ben-Yossef
Chief Coffee Drinker
"If you take a class in large-scale robotics, can you end up in a
situation where the homework eats your dog?"
-- Jean-Baptiste Queru
[toc] | [prev] | [next] | [standalone]
| From | Srishti Sharma <srishtishar@gmail.com> |
|---|---|
| Date | 2017-09-07 12:00 +0200 |
| Message-ID | <un1Lk-6F4-13@gated-at.bofh.it> |
| In reply to | #1728047 |
On Thu, Sep 7, 2017 at 2:20 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> Hi,
>
> On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma <srishtishar@gmail.com> wrote:
>> Remove the local variable inflight_counter as it is never used.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>> ---
>
> I've been meaning to clean that for some time now and never got around to do it.
> Thank you! :-)
Glad to know :)
>
> Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
>
>
>> Changes in v5:
>> - Correct the format of the subject.
>> drivers/staging/ccree/ssi_cipher.c | 3 ---
>> 1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
>> index 8d31a93..1ff3c8a 100644
>> --- a/drivers/staging/ccree/ssi_cipher.c
>> +++ b/drivers/staging/ccree/ssi_cipher.c
>> @@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
>> void __iomem *cc_base)
>> {
>> int completion_error = 0;
>> - u32 inflight_counter;
>> struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
>>
>> ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>>
>> - /*Set the inflight couter value to local variable*/
>> - inflight_counter = ctx_p->drvdata->inflight_counter;
>> /*Decrease the inflight counter*/
>> if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
>> ctx_p->drvdata->inflight_counter--;
>> --
>> 2.7.4
>>
>
>
>
> --
> Gilad Ben-Yossef
> Chief Coffee Drinker
>
> "If you take a class in large-scale robotics, can you end up in a
> situation where the homework eats your dog?"
> -- Jean-Baptiste Queru
Regards,
Srishti
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web