Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1728104

Re: [PATCH v5] Staging: ccree: Remove unused variable.

Show all headers | View raw

On Thu, Sep 7, 2017 at 2:20 PM, Gilad Ben-Yossef <gilad@benyossef.com> wrote:
> Hi,
>
> On Thu, Sep 7, 2017 at 10:49 AM, Srishti Sharma <srishtishar@gmail.com> wrote:
>> Remove the local variable inflight_counter as it is never used.
>>
>> Signed-off-by: Srishti Sharma <srishtishar@gmail.com>
>> ---
>
> I've been meaning to clean that for some time now and never got around to do it.
> Thank you! :-)

Glad to know :)

>
> Acked-by: Gilad Ben-Yossef <gilad@benyossef.com>
>
>
>> Changes in v5:
>>  - Correct the format of the subject.
>>  drivers/staging/ccree/ssi_cipher.c | 3 ---
>>  1 file changed, 3 deletions(-)
>>
>> diff --git a/drivers/staging/ccree/ssi_cipher.c b/drivers/staging/ccree/ssi_cipher.c
>> index 8d31a93..1ff3c8a 100644
>> --- a/drivers/staging/ccree/ssi_cipher.c
>> +++ b/drivers/staging/ccree/ssi_cipher.c
>> @@ -697,13 +697,10 @@ static int ssi_blkcipher_complete(struct device *dev,
>>                                   void __iomem *cc_base)
>>  {
>>         int completion_error = 0;
>> -       u32 inflight_counter;
>>         struct ablkcipher_request *req = (struct ablkcipher_request *)areq;
>>
>>         ssi_buffer_mgr_unmap_blkcipher_request(dev, req_ctx, ivsize, src, dst);
>>
>> -       /*Set the inflight couter value to local variable*/
>> -       inflight_counter =  ctx_p->drvdata->inflight_counter;
>>         /*Decrease the inflight counter*/
>>         if (ctx_p->flow_mode == BYPASS && ctx_p->drvdata->inflight_counter > 0)
>>                 ctx_p->drvdata->inflight_counter--;
>> --
>> 2.7.4
>>
>
>
>
> --
> Gilad Ben-Yossef
> Chief Coffee Drinker
>
> "If you take a class in large-scale robotics, can you end up in a
> situation where the homework eats your dog?"
>  -- Jean-Baptiste Queru

Regards,
Srishti

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v5] Staging: ccree: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-07 09:50 +0200
  Re: [PATCH v5] Staging: ccree: Remove unused variable. Dan Carpenter <dan.carpenter@oracle.com> - 2017-09-07 10:00 +0200
  Re: [Outreachy kernel] [PATCH v5] Staging: ccree: Remove unused  variable. Julia Lawall <julia.lawall@lip6.fr> - 2017-09-07 10:30 +0200
  Re: [PATCH v5] Staging: ccree: Remove unused variable. Gilad Ben-Yossef <gilad@benyossef.com> - 2017-09-07 11:00 +0200
    Re: [PATCH v5] Staging: ccree: Remove unused variable. Srishti Sharma <srishtishar@gmail.com> - 2017-09-07 12:00 +0200

csiph-web