Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1727933 > unrolled thread

[PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err

Started byBjorn Andersson <bjorn.andersson@linaro.org>
First post2017-09-07 08:10 +0200
Last post2017-09-07 08:10 +0200
Articles 1 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  [PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-09-07 08:10 +0200

#1727933 — [PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err

FromBjorn Andersson <bjorn.andersson@linaro.org>
Date2017-09-07 08:10 +0200
Subject[PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err
Message-ID<umYaK-4pA-31@gated-at.bofh.it>
Rather than manually waking up any context sleeping on the sock to
signal an error we should call sk_error_report(). This has the added
benefit that in-kernel consumers can override this notificatino with
its own callback.

Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
---
 net/qrtr/qrtr.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c
index 5586609afa27..2058b27821a4 100644
--- a/net/qrtr/qrtr.c
+++ b/net/qrtr/qrtr.c
@@ -541,7 +541,7 @@ static void qrtr_reset_ports(void)
 
 		sock_hold(&ipc->sk);
 		ipc->sk.sk_err = ENETRESET;
-		wake_up_interruptible(sk_sleep(&ipc->sk));
+		ipc->sk.sk_error_report(&ipc->sk);
 		sock_put(&ipc->sk);
 	}
 	mutex_unlock(&qrtr_port_lock);
-- 
2.12.0

[toc] | [standalone]


Back to top | Article view | linux.kernel


csiph-web