Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1727933
| From | Bjorn Andersson <bjorn.andersson@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err |
| Date | 2017-09-07 08:10 +0200 |
| Message-ID | <umYaK-4pA-31@gated-at.bofh.it> (permalink) |
| References | <umYaJ-4pA-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Rather than manually waking up any context sleeping on the sock to signal an error we should call sk_error_report(). This has the added benefit that in-kernel consumers can override this notificatino with its own callback. Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> --- net/qrtr/qrtr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/qrtr/qrtr.c b/net/qrtr/qrtr.c index 5586609afa27..2058b27821a4 100644 --- a/net/qrtr/qrtr.c +++ b/net/qrtr/qrtr.c @@ -541,7 +541,7 @@ static void qrtr_reset_ports(void) sock_hold(&ipc->sk); ipc->sk.sk_err = ENETRESET; - wake_up_interruptible(sk_sleep(&ipc->sk)); + ipc->sk.sk_error_report(&ipc->sk); sock_put(&ipc->sk); } mutex_unlock(&qrtr_port_lock); -- 2.12.0
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 1/7] net: qrtr: Invoke sk_error_report() after setting sk_err Bjorn Andersson <bjorn.andersson@linaro.org> - 2017-09-07 08:10 +0200
csiph-web