Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1727367 > unrolled thread

Re: [PATCH] MIPS: ath79: support devicetree selection

Started byRalf Baechle <ralf@linux-mips.org>
First post2017-09-06 13:20 +0200
Last post2017-09-06 16:10 +0200
Articles 6 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] MIPS: ath79: support devicetree selection Ralf Baechle <ralf@linux-mips.org> - 2017-09-06 13:20 +0200
    Re: [PATCH] MIPS: ath79: support devicetree selection Rocco Folino <rocco.folino@gmail.com> - 2017-09-06 14:10 +0200
    Re: [PATCH] MIPS: ath79: support devicetree selection Alban <albeu@free.fr> - 2017-09-06 14:30 +0200
      Re: [PATCH] MIPS: ath79: support devicetree selection Rocco Folino <rocco.folino@gmail.com> - 2017-09-06 14:40 +0200
        Re: [PATCH] MIPS: ath79: support devicetree selection Alban <albeu@free.fr> - 2017-09-06 15:40 +0200
          Re: [PATCH] MIPS: ath79: support devicetree selection Rocco Folino <rocco.folino@gmail.com> - 2017-09-06 16:10 +0200

#1727367 — Re: [PATCH] MIPS: ath79: support devicetree selection

FromRalf Baechle <ralf@linux-mips.org>
Date2017-09-06 13:20 +0200
SubjectRe: [PATCH] MIPS: ath79: support devicetree selection
Message-ID<umGxd-Yr-41@gated-at.bofh.it>
On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:

> Allow to choose devicetrees from Kconfig.
> 
> Signed-off-by: Rocco Folino <rocco.folino@gmail.com>
> ---
>  arch/mips/ath79/Kconfig         | 44 +++++++++++++++++++++++++++++++++++++++++
>  arch/mips/boot/dts/qca/Makefile | 10 +++++-----
>  2 files changed, 49 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
> index dfc60209dc63..b43d116187af 100644
> --- a/arch/mips/ath79/Kconfig
> +++ b/arch/mips/ath79/Kconfig
> @@ -1,5 +1,49 @@
>  if ATH79
>  
> +menu "Atheros AR71XX/AR724X/AR913X devicetree selection"
> +
> +config DTB_ATH_DPT_MODULE
> +	bool "DPTechnics DPT-Module"
> +	select SOC_933X

There is no symbol SOC_933X.  Did you mean SOC_AR933X?

Anyway, your patch does more than the changelog ("Allow to choose
devicetrees from Kconfig") says, so please either fix the changelog
or split that into multiple patches with proper changelogs.

  Ralf

[toc] | [next] | [standalone]

#1727384

FromRocco Folino <rocco.folino@gmail.com>
Date2017-09-06 14:10 +0200
Message-ID<umHjA-1yw-13@gated-at.bofh.it>
In reply to#1727367
On Wed, Sep 06, 2017 at 01:14:35PM +0200, Ralf Baechle wrote:
> On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> 
> > Allow to choose devicetrees from Kconfig.
> > 
> > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>
> > ---
> >  arch/mips/ath79/Kconfig         | 44 +++++++++++++++++++++++++++++++++++++++++
> >  arch/mips/boot/dts/qca/Makefile | 10 +++++-----
> >  2 files changed, 49 insertions(+), 5 deletions(-)
> > 
> > diff --git a/arch/mips/ath79/Kconfig b/arch/mips/ath79/Kconfig
> > index dfc60209dc63..b43d116187af 100644
> > --- a/arch/mips/ath79/Kconfig
> > +++ b/arch/mips/ath79/Kconfig
> > @@ -1,5 +1,49 @@
> >  if ATH79
> >  
> > +menu "Atheros AR71XX/AR724X/AR913X devicetree selection"
> > +
> > +config DTB_ATH_DPT_MODULE
> > +	bool "DPTechnics DPT-Module"
> > +	select SOC_933X
> 
> There is no symbol SOC_933X.  Did you mean SOC_AR933X?

Yes, right

> 
> Anyway, your patch does more than the changelog ("Allow to choose
> devicetrees from Kconfig") says, so please either fix the changelog
> or split that into multiple patches with proper changelogs.

Ok, I'll fix everything in the v2

thanks for the comments.

Rocco

[toc] | [prev] | [next] | [standalone]

#1727392

FromAlban <albeu@free.fr>
Date2017-09-06 14:30 +0200
Message-ID<umHCW-1G1-11@gated-at.bofh.it>
In reply to#1727367

[Multipart message — attachments visible in raw view] — view raw

On Wed, 6 Sep 2017 13:14:35 +0200
Ralf Baechle <ralf@linux-mips.org> wrote:

> On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> 
> > Allow to choose devicetrees from Kconfig.
> > 
> > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>

I don't really see the point of this patch. Building the dtb doesn't
take any significant time, so why add this extra complexity?

Alban

[toc] | [prev] | [next] | [standalone]

#1727403

FromRocco Folino <rocco.folino@gmail.com>
Date2017-09-06 14:40 +0200
Message-ID<umHMD-1JN-25@gated-at.bofh.it>
In reply to#1727392
On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> On Wed, 6 Sep 2017 13:14:35 +0200
> Ralf Baechle <ralf@linux-mips.org> wrote:
> 
> > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > 
> > > Allow to choose devicetrees from Kconfig.
> > > 
> > > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>
> 
> I don't really see the point of this patch. Building the dtb doesn't
> take any significant time, so why add this extra complexity?

Because you need to select the SoC type in order to enable some drivers, for
example on the AR9331 to use the serial you need the CONFIG_SERIAL_AR933X
which depends on the CONFIG_SOC_AR933X.

Rocco

[toc] | [prev] | [next] | [standalone]

#1727474

FromAlban <albeu@free.fr>
Date2017-09-06 15:40 +0200
Message-ID<umIIF-2qh-5@gated-at.bofh.it>
In reply to#1727403

[Multipart message — attachments visible in raw view] — view raw

On Wed, 6 Sep 2017 14:32:00 +0200
Rocco Folino <rocco.folino@gmail.com> wrote:

> On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> > On Wed, 6 Sep 2017 13:14:35 +0200
> > Ralf Baechle <ralf@linux-mips.org> wrote:
> >   
> > > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > >   
> > > > Allow to choose devicetrees from Kconfig.
> > > > 
> > > > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>  
> > 
> > I don't really see the point of this patch. Building the dtb doesn't
> > take any significant time, so why add this extra complexity?  
> 
> Because you need to select the SoC type in order to enable some
> drivers, for example on the AR9331 to use the serial you need the
> CONFIG_SERIAL_AR933X which depends on the CONFIG_SOC_AR933X.

Seeing as this driver is the only one that make use of CONFIG_SOC_AR933X
I would prefer removing this dependency. It would also open the way to have
the driver built in COMPILE_TEST. A few more fixes might be needed but that
would be better than such a workaround.

Alban

[toc] | [prev] | [next] | [standalone]

#1727521

FromRocco Folino <rocco.folino@gmail.com>
Date2017-09-06 16:10 +0200
Message-ID<umJbI-2R0-7@gated-at.bofh.it>
In reply to#1727474
On Wed, Sep 06, 2017 at 03:35:43PM +0200, Alban wrote:
> On Wed, 6 Sep 2017 14:32:00 +0200
> Rocco Folino <rocco.folino@gmail.com> wrote:
> 
> > On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> > > On Wed, 6 Sep 2017 13:14:35 +0200
> > > Ralf Baechle <ralf@linux-mips.org> wrote:
> > >   
> > > > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > > >   
> > > > > Allow to choose devicetrees from Kconfig.
> > > > > 
> > > > > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>  
> > > 
> > > I don't really see the point of this patch. Building the dtb doesn't
> > > take any significant time, so why add this extra complexity?  
> > 
> > Because you need to select the SoC type in order to enable some
> > drivers, for example on the AR9331 to use the serial you need the
> > CONFIG_SERIAL_AR933X which depends on the CONFIG_SOC_AR933X.
> 
> Seeing as this driver is the only one that make use of CONFIG_SOC_AR933X
> I would prefer removing this dependency. It would also open the way to have
> the driver built in COMPILE_TEST. A few more fixes might be needed but that
> would be better than such a workaround.

Yes, I agree!

Thanks,

Rocco

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web