Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1727474

Re: [PATCH] MIPS: ath79: support devicetree selection

From Alban <albeu@free.fr>
Newsgroups linux.kernel
Subject Re: [PATCH] MIPS: ath79: support devicetree selection
Date 2017-09-06 15:40 +0200
Message-ID <umIIF-2qh-5@gated-at.bofh.it> (permalink)
References <ufRxn-5DE-7@gated-at.bofh.it> <umGxd-Yr-41@gated-at.bofh.it> <umHCW-1G1-11@gated-at.bofh.it> <umHMD-1JN-25@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


[Multipart message — attachments visible in raw view] - view raw

On Wed, 6 Sep 2017 14:32:00 +0200
Rocco Folino <rocco.folino@gmail.com> wrote:

> On Wed, Sep 06, 2017 at 02:20:05PM +0200, Alban wrote:
> > On Wed, 6 Sep 2017 13:14:35 +0200
> > Ralf Baechle <ralf@linux-mips.org> wrote:
> >   
> > > On Fri, Aug 18, 2017 at 05:32:42PM +0200, Rocco Folino wrote:
> > >   
> > > > Allow to choose devicetrees from Kconfig.
> > > > 
> > > > Signed-off-by: Rocco Folino <rocco.folino@gmail.com>  
> > 
> > I don't really see the point of this patch. Building the dtb doesn't
> > take any significant time, so why add this extra complexity?  
> 
> Because you need to select the SoC type in order to enable some
> drivers, for example on the AR9331 to use the serial you need the
> CONFIG_SERIAL_AR933X which depends on the CONFIG_SOC_AR933X.

Seeing as this driver is the only one that make use of CONFIG_SOC_AR933X
I would prefer removing this dependency. It would also open the way to have
the driver built in COMPILE_TEST. A few more fixes might be needed but that
would be better than such a workaround.

Alban

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

Re: [PATCH] MIPS: ath79: support devicetree selection Ralf Baechle <ralf@linux-mips.org> - 2017-09-06 13:20 +0200
  Re: [PATCH] MIPS: ath79: support devicetree selection Rocco Folino <rocco.folino@gmail.com> - 2017-09-06 14:10 +0200
  Re: [PATCH] MIPS: ath79: support devicetree selection Alban <albeu@free.fr> - 2017-09-06 14:30 +0200
    Re: [PATCH] MIPS: ath79: support devicetree selection Rocco Folino <rocco.folino@gmail.com> - 2017-09-06 14:40 +0200
      Re: [PATCH] MIPS: ath79: support devicetree selection Alban <albeu@free.fr> - 2017-09-06 15:40 +0200
        Re: [PATCH] MIPS: ath79: support devicetree selection Rocco Folino <rocco.folino@gmail.com> - 2017-09-06 16:10 +0200

csiph-web