Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1727252 > unrolled thread
| Started by | Bastien Nocera <hadess@hadess.net> |
|---|---|
| First post | 2017-09-06 11:10 +0200 |
| Last post | 2017-09-07 02:40 +0200 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3] Input: goodix: Add support for capacitive home button Bastien Nocera <hadess@hadess.net> - 2017-09-06 11:10 +0200
Re: [PATCH v3] Input: goodix: Add support for capacitive home button Jiri Kosina <jikos@kernel.org> - 2017-09-06 11:10 +0200
Re: [PATCH v3] Input: goodix: Add support for capacitive home button Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-07 02:40 +0200
| From | Bastien Nocera <hadess@hadess.net> |
|---|---|
| Date | 2017-09-06 11:10 +0200 |
| Subject | Re: [PATCH v3] Input: goodix: Add support for capacitive home button |
| Message-ID | <umEvo-7XC-7@gated-at.bofh.it> |
Hey, On Tue, 2017-06-20 at 18:08 +0200, Bastien Nocera wrote: > From: "Sergei A. Trusov" <sergei.a.trusov@ya.ru> > > On some x86 tablets with a Goodix touchscreen, the Windows logo on > the > front is a capacitive home button. Touching this button results in a > touch > with bit 4 of the first byte set, while only the lower 4 bits (0-3) > are > used to indicate the number of touches. > > Report a KEY_LEFTMETA press when this happens. > > Note that the hardware might support more than one button, in which > case the "id" byte of coor_data would identify the button in > question. > This is not implemented as we don't have access to hardware with > multiple buttons. > > Signed-off-by: Sergei A. Trusov <sergei.a.trusov@ya.ru> > Acked-by: Bastien Nocera <hadess@hadess.net> Can we please get this merged? I didn't receive any reviews on it, and it's been sitting there for 2 months...
[toc] | [next] | [standalone]
| From | Jiri Kosina <jikos@kernel.org> |
|---|---|
| Date | 2017-09-06 11:10 +0200 |
| Subject | Re: [PATCH v3] Input: goodix: Add support for capacitive home button |
| Message-ID | <umEvq-7XC-59@gated-at.bofh.it> |
| In reply to | #1727252 |
On Wed, 6 Sep 2017, Bastien Nocera wrote: > Hey, > > On Tue, 2017-06-20 at 18:08 +0200, Bastien Nocera wrote: > > From: "Sergei A. Trusov" <sergei.a.trusov@ya.ru> > > > > On some x86 tablets with a Goodix touchscreen, the Windows logo on > > the > > front is a capacitive home button. Touching this button results in a > > touch > > with bit 4 of the first byte set, while only the lower 4 bits (0-3) > > are > > used to indicate the number of touches. > > > > Report a KEY_LEFTMETA press when this happens. > > > > Note that the hardware might support more than one button, in which > > case the "id" byte of coor_data would identify the button in > > question. > > This is not implemented as we don't have access to hardware with > > multiple buttons. > > > > Signed-off-by: Sergei A. Trusov <sergei.a.trusov@ya.ru> > > Acked-by: Bastien Nocera <hadess@hadess.net> > > Can we please get this merged? I didn't receive any reviews on it, and > it's been sitting there for 2 months... Let's CC Dmitry. -- Jiri Kosina SUSE Labs
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2017-09-07 02:40 +0200 |
| Message-ID | <umT1n-KQ-7@gated-at.bofh.it> |
| In reply to | #1727268 |
On Wed, Sep 06, 2017 at 11:03:06AM +0200, Jiri Kosina wrote: > On Wed, 6 Sep 2017, Bastien Nocera wrote: > > > Hey, > > > > On Tue, 2017-06-20 at 18:08 +0200, Bastien Nocera wrote: > > > From: "Sergei A. Trusov" <sergei.a.trusov@ya.ru> > > > > > > On some x86 tablets with a Goodix touchscreen, the Windows logo on > > > the > > > front is a capacitive home button. Touching this button results in a > > > touch > > > with bit 4 of the first byte set, while only the lower 4 bits (0-3) > > > are > > > used to indicate the number of touches. > > > > > > Report a KEY_LEFTMETA press when this happens. > > > > > > Note that the hardware might support more than one button, in which > > > case the "id" byte of coor_data would identify the button in > > > question. > > > This is not implemented as we don't have access to hardware with > > > multiple buttons. > > > > > > Signed-off-by: Sergei A. Trusov <sergei.a.trusov@ya.ru> > > > Acked-by: Bastien Nocera <hadess@hadess.net> > > > > Can we please get this merged? I didn't receive any reviews on it, and > > it's been sitting there for 2 months... > > Let's CC Dmitry. Applied, thank you. -- Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web