Re: [PATCH v3] Input: goodix: Add support for capacitive home button

From	Jiri Kosina <jikos@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3] Input: goodix: Add support for capacitive home button
Date	2017-09-06 11:10 +0200
Message-ID	<umEvq-7XC-59@gated-at.bofh.it> (permalink)
References	<tUtT5-2pP-41@gated-at.bofh.it> <umEvo-7XC-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 6 Sep 2017, Bastien Nocera wrote:

> Hey,
> 
> On Tue, 2017-06-20 at 18:08 +0200, Bastien Nocera wrote:
> > From: "Sergei A. Trusov" <sergei.a.trusov@ya.ru>
> > 
> > On some x86 tablets with a Goodix touchscreen, the Windows logo on
> > the
> > front is a capacitive home button. Touching this button results in a
> > touch
> > with bit 4 of the first byte set, while only the lower 4 bits (0-3)
> > are
> > used to indicate the number of touches.
> > 
> > Report a KEY_LEFTMETA press when this happens.
> > 
> > Note that the hardware might support more than one button, in which
> > case the "id" byte of coor_data would identify the button in
> > question.
> > This is not implemented as we don't have access to hardware with
> > multiple buttons.
> > 
> > Signed-off-by: Sergei A. Trusov <sergei.a.trusov@ya.ru>
> > Acked-by: Bastien Nocera <hadess@hadess.net>
> 
> Can we please get this merged? I didn't receive any reviews on it, and
> it's been sitting there for 2 months...

Let's CC Dmitry.

-- 
Jiri Kosina
SUSE Labs

Thread

Re: [PATCH v3] Input: goodix: Add support for capacitive home button Bastien Nocera <hadess@hadess.net> - 2017-09-06 11:10 +0200
  Re: [PATCH v3] Input: goodix: Add support for capacitive home  button Jiri Kosina <jikos@kernel.org> - 2017-09-06 11:10 +0200
    Re: [PATCH v3] Input: goodix: Add support for capacitive home button Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2017-09-07 02:40 +0200

csiph-web