Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1723342 > unrolled thread
| Started by | Heiko Stübner <heiko@sntech.de> |
|---|---|
| First post | 2017-08-30 15:40 +0200 |
| Last post | 2017-09-05 06:30 +0200 |
| Articles | 4 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru Heiko Stübner <heiko@sntech.de> - 2017-08-30 15:40 +0200
Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru jeffy <jeffy.chen@rock-chips.com> - 2017-08-30 19:10 +0200
Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru Heiko Stübner <heiko@sntech.de> - 2017-09-05 00:40 +0200
Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru jeffy <jeffy.chen@rock-chips.com> - 2017-09-05 06:30 +0200
| From | Heiko Stübner <heiko@sntech.de> |
|---|---|
| Date | 2017-08-30 15:40 +0200 |
| Subject | Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru |
| Message-ID | <ukbnQ-rR-23@gated-at.bofh.it> |
Hi Jeffy,
Am Donnerstag, 24. August 2017, 12:52:23 CEST schrieb Jeffy Chen:
> Currently the rt5514 i2c driver and rt5514 spi driver are using the same
> compatible string.
>
> Add additional unused compatible strings to identify them for Gru
> boards.
>
> Signed-off-by: Jeffy Chen <jeffy.chen@rock-chips.com>
> ---
>
> Changes in v7: None
> Changes in v6: None
> Changes in v3: None
> Changes in v2: None
>
> arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi index
> 5772c52fbfd3..50fb11ad9f17 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-gru.dtsi
> @@ -611,7 +611,7 @@ ap_i2c_mic: &i2c1 {
> i2c-scl-rising-time-ns = <300>;
>
> headsetcodec: rt5514@57 {
> - compatible = "realtek,rt5514";
> + compatible = "realtek,rt5514", "realtek,rt5514-i2c";
the rt5514-i2c and -spi compatibles should be documented in the binding-txt
of the chip, but I haven't found any mention of this.
Heiko
[toc] | [next] | [standalone]
| From | jeffy <jeffy.chen@rock-chips.com> |
|---|---|
| Date | 2017-08-30 19:10 +0200 |
| Subject | Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru |
| Message-ID | <ukeF4-2E4-25@gated-at.bofh.it> |
| In reply to | #1723342 |
Hi Heiko, thanks for your reply. On 08/30/2017 09:30 PM, Heiko Stübner wrote: >> >- compatible = "realtek,rt5514"; >> >+ compatible = "realtek,rt5514", "realtek,rt5514-i2c"; > the rt5514-i2c and -spi compatibles should be documented in the binding-txt > of the chip, but I haven't found any mention of this. > > > Heiko these compatibles are only used for our snd driver to detect rt5514 i2c driver and rt5514 spi driver, suggested by Matthias at https://patchwork.kernel.org/patch/9904731/ should i add it in the rockchip,rk3399-gru-sound.txt or rt5514 binding document?
[toc] | [prev] | [next] | [standalone]
| From | Heiko Stübner <heiko@sntech.de> |
|---|---|
| Date | 2017-09-05 00:40 +0200 |
| Message-ID | <um8ca-2S5-15@gated-at.bofh.it> |
| In reply to | #1723510 |
Am Donnerstag, 31. August 2017, 01:00:44 CEST schrieb jeffy: > On 08/30/2017 09:30 PM, Heiko Stübner wrote: > >> >- compatible = "realtek,rt5514"; > >> >+ compatible = "realtek,rt5514", "realtek,rt5514-i2c"; > > > > the rt5514-i2c and -spi compatibles should be documented in the > > binding-txt > > of the chip, but I haven't found any mention of this. > > > > > > Heiko > > these compatibles are only used for our snd driver to detect rt5514 i2c > driver and rt5514 spi driver, suggested by Matthias at > https://patchwork.kernel.org/patch/9904731/ > > should i add it in the rockchip,rk3399-gru-sound.txt or rt5514 binding > document? You're introducing new bindings for the codec, so they should of course part of the rt5514 binding. Heiko
[toc] | [prev] | [next] | [standalone]
| From | jeffy <jeffy.chen@rock-chips.com> |
|---|---|
| Date | 2017-09-05 06:30 +0200 |
| Subject | Re: [RESENT PATCH v7 3/7] arm64: dts: rockchip: Update rt5514 devices' compatible for Gru |
| Message-ID | <umdES-6pB-13@gated-at.bofh.it> |
| In reply to | #1726275 |
Hi Heiko, On 09/05/2017 06:33 AM, Heiko Stübner wrote: > Am Donnerstag, 31. August 2017, 01:00:44 CEST schrieb jeffy: >> On 08/30/2017 09:30 PM, Heiko Stübner wrote: >>>>> - compatible = "realtek,rt5514"; >>>>> + compatible = "realtek,rt5514", "realtek,rt5514-i2c"; >>> >>> the rt5514-i2c and -spi compatibles should be documented in the >>> binding-txt >>> of the chip, but I haven't found any mention of this. >>> >>> >>> Heiko >> >> these compatibles are only used for our snd driver to detect rt5514 i2c >> driver and rt5514 spi driver, suggested by Matthias at >> https://patchwork.kernel.org/patch/9904731/ >> >> should i add it in the rockchip,rk3399-gru-sound.txt or rt5514 binding >> document? > > You're introducing new bindings for the codec, so they should of course > part of the rt5514 binding. ok, will do that. and it looks like there's no binding for rt5514-spi, will add it too :) > > > Heiko > > > >
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web