Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1722701 > unrolled thread
| Started by | Himanshu Jha <himanshujha199640@gmail.com> |
|---|---|
| First post | 2017-08-29 21:10 +0200 |
| Last post | 2017-09-02 14:50 +0200 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] drm/amdkfd: remove memset before memcpy Himanshu Jha <himanshujha199640@gmail.com> - 2017-08-29 21:10 +0200
Re: [PATCH] drm/amdkfd: remove memset before memcpy Oded Gabbay <oded.gabbay@gmail.com> - 2017-09-02 14:50 +0200
| From | Himanshu Jha <himanshujha199640@gmail.com> |
|---|---|
| Date | 2017-08-29 21:10 +0200 |
| Subject | [PATCH] drm/amdkfd: remove memset before memcpy |
| Message-ID | <ujU3D-6AB-7@gated-at.bofh.it> |
calling memcpy immediately after memset with the same region of memory makes memset redundant. Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> --- drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c index 1cae95e..03bec76 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c @@ -143,7 +143,6 @@ int pqm_create_queue(struct process_queue_manager *pqm, int num_queues = 0; struct queue *cur; - memset(&q_properties, 0, sizeof(struct queue_properties)); memcpy(&q_properties, properties, sizeof(struct queue_properties)); q = NULL; kq = NULL; -- 2.7.4
[toc] | [next] | [standalone]
| From | Oded Gabbay <oded.gabbay@gmail.com> |
|---|---|
| Date | 2017-09-02 14:50 +0200 |
| Message-ID | <ulg26-317-7@gated-at.bofh.it> |
| In reply to | #1722701 |
On Tue, Aug 29, 2017 at 10:03 PM, Himanshu Jha <himanshujha199640@gmail.com> wrote: > calling memcpy immediately after memset with the same region of memory > makes memset redundant. > > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> > --- > drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c > index 1cae95e..03bec76 100644 > --- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c > @@ -143,7 +143,6 @@ int pqm_create_queue(struct process_queue_manager *pqm, > int num_queues = 0; > struct queue *cur; > > - memset(&q_properties, 0, sizeof(struct queue_properties)); > memcpy(&q_properties, properties, sizeof(struct queue_properties)); > q = NULL; > kq = NULL; > -- > 2.7.4 > Thanks! Applied to amdkfd -next tree Oded
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web