[PATCH] drm/amdkfd: remove memset before memcpy

From	Himanshu Jha <himanshujha199640@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH] drm/amdkfd: remove memset before memcpy
Date	2017-08-29 21:10 +0200
Message-ID	<ujU3D-6AB-7@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

calling memcpy immediately after memset with the same region of memory
makes memset redundant.

Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
---
 drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
index 1cae95e..03bec76 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_process_queue_manager.c
@@ -143,7 +143,6 @@ int pqm_create_queue(struct process_queue_manager *pqm,
 	int num_queues = 0;
 	struct queue *cur;
 
-	memset(&q_properties, 0, sizeof(struct queue_properties));
 	memcpy(&q_properties, properties, sizeof(struct queue_properties));
 	q = NULL;
 	kq = NULL;
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/amdkfd: remove memset before memcpy Himanshu Jha <himanshujha199640@gmail.com> - 2017-08-29 21:10 +0200
  Re: [PATCH] drm/amdkfd: remove memset before memcpy Oded Gabbay <oded.gabbay@gmail.com> - 2017-09-02 14:50 +0200

csiph-web