Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725011 > unrolled thread

[PATCH] f2fs: clear get_ssr_cost

Started byYunlong Song <yunlong.song@huawei.com>
First post2017-09-01 14:20 +0200
Last post2017-09-04 05:20 +0200
Articles 5 — 2 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] f2fs: clear get_ssr_cost Yunlong Song <yunlong.song@huawei.com> - 2017-09-01 14:20 +0200
    Re: [PATCH] f2fs: clear get_ssr_cost Chao Yu <yuchao0@huawei.com> - 2017-09-04 03:20 +0200
      Re: [PATCH] f2fs: clear get_ssr_cost Yunlong Song <yunlong.song@huawei.com> - 2017-09-04 04:00 +0200
        Re: [PATCH] f2fs: clear get_ssr_cost Chao Yu <yuchao0@huawei.com> - 2017-09-04 04:50 +0200
    [PATCH v2] Revert "f2fs: add a new function get_ssr_cost" Yunlong Song <yunlong.song@huawei.com> - 2017-09-04 05:20 +0200

#1725011 — [PATCH] f2fs: clear get_ssr_cost

FromYunlong Song <yunlong.song@huawei.com>
Date2017-09-01 14:20 +0200
Subject[PATCH] f2fs: clear get_ssr_cost
Message-ID<ukT5w-4mh-25@gated-at.bofh.it>
se->ckpt_valid_blocks is always larger than se->valid_blocks, so
get_ssr_cost can be cleared.

Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
 fs/f2fs/gc.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index cd147e7..b226760 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -277,20 +277,11 @@ static unsigned int get_greedy_cost(struct f2fs_sb_info *sbi,
 				valid_blocks * 2 : valid_blocks;
 }
 
-static unsigned int get_ssr_cost(struct f2fs_sb_info *sbi,
-						unsigned int segno)
-{
-	struct seg_entry *se = get_seg_entry(sbi, segno);
-
-	return se->ckpt_valid_blocks > se->valid_blocks ?
-				se->ckpt_valid_blocks : se->valid_blocks;
-}
-
 static inline unsigned int get_gc_cost(struct f2fs_sb_info *sbi,
 			unsigned int segno, struct victim_sel_policy *p)
 {
 	if (p->alloc_mode == SSR)
-		return get_ssr_cost(sbi, segno);
+		return get_seg_entry(sbi, segno)->ckpt_valid_blocks;
 
 	/* alloc_mode == LFS */
 	if (p->gc_mode == GC_GREEDY)
-- 
1.8.5.2

[toc] | [next] | [standalone]

#1725797

FromChao Yu <yuchao0@huawei.com>
Date2017-09-04 03:20 +0200
Message-ID<ulOdr-7lZ-7@gated-at.bofh.it>
In reply to#1725011
On 2017/9/1 20:14, Yunlong Song wrote:
> se->ckpt_valid_blocks is always larger than se->valid_blocks, so
> get_ssr_cost can be cleared.

I think this is not correct.

Thanks,

> 
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
>  fs/f2fs/gc.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index cd147e7..b226760 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -277,20 +277,11 @@ static unsigned int get_greedy_cost(struct f2fs_sb_info *sbi,
>  				valid_blocks * 2 : valid_blocks;
>  }
>  
> -static unsigned int get_ssr_cost(struct f2fs_sb_info *sbi,
> -						unsigned int segno)
> -{
> -	struct seg_entry *se = get_seg_entry(sbi, segno);
> -
> -	return se->ckpt_valid_blocks > se->valid_blocks ?
> -				se->ckpt_valid_blocks : se->valid_blocks;
> -}
> -
>  static inline unsigned int get_gc_cost(struct f2fs_sb_info *sbi,
>  			unsigned int segno, struct victim_sel_policy *p)
>  {
>  	if (p->alloc_mode == SSR)
> -		return get_ssr_cost(sbi, segno);
> +		return get_seg_entry(sbi, segno)->ckpt_valid_blocks;
>  
>  	/* alloc_mode == LFS */
>  	if (p->gc_mode == GC_GREEDY)
>

[toc] | [prev] | [next] | [standalone]

#1725808

FromYunlong Song <yunlong.song@huawei.com>
Date2017-09-04 04:00 +0200
Message-ID<ulOQ9-7yp-1@gated-at.bofh.it>
In reply to#1725797
The update_sit_entry provides this:
...
1658     if (!f2fs_test_bit(offset, se->ckpt_valid_map))
1659         se->ckpt_valid_blocks += del;
...
As a result, the ckpt_valid_blocks is always larger than valid_blocks. 
If not correct, can you provide
the case valid_blocks larger than ckpt_valid_blocks?

On 2017/9/4 9:17, Chao Yu wrote:
> On 2017/9/1 20:14, Yunlong Song wrote:
>> se->ckpt_valid_blocks is always larger than se->valid_blocks, so
>> get_ssr_cost can be cleared.
> I think this is not correct.
>
> Thanks,
>
>> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
>> ---
>>   fs/f2fs/gc.c | 11 +----------
>>   1 file changed, 1 insertion(+), 10 deletions(-)
>>
>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
>> index cd147e7..b226760 100644
>> --- a/fs/f2fs/gc.c
>> +++ b/fs/f2fs/gc.c
>> @@ -277,20 +277,11 @@ static unsigned int get_greedy_cost(struct f2fs_sb_info *sbi,
>>   				valid_blocks * 2 : valid_blocks;
>>   }
>>   
>> -static unsigned int get_ssr_cost(struct f2fs_sb_info *sbi,
>> -						unsigned int segno)
>> -{
>> -	struct seg_entry *se = get_seg_entry(sbi, segno);
>> -
>> -	return se->ckpt_valid_blocks > se->valid_blocks ?
>> -				se->ckpt_valid_blocks : se->valid_blocks;
>> -}
>> -
>>   static inline unsigned int get_gc_cost(struct f2fs_sb_info *sbi,
>>   			unsigned int segno, struct victim_sel_policy *p)
>>   {
>>   	if (p->alloc_mode == SSR)
>> -		return get_ssr_cost(sbi, segno);
>> +		return get_seg_entry(sbi, segno)->ckpt_valid_blocks;
>>   
>>   	/* alloc_mode == LFS */
>>   	if (p->gc_mode == GC_GREEDY)
>>
>
> .
>

-- 
Thanks,
Yunlong Song

[toc] | [prev] | [next] | [standalone]

#1725814

FromChao Yu <yuchao0@huawei.com>
Date2017-09-04 04:50 +0200
Message-ID<ulPCx-8bq-1@gated-at.bofh.it>
In reply to#1725808
On 2017/9/4 9:54, Yunlong Song wrote:
> The update_sit_entry provides this:
> ...
> 1658     if (!f2fs_test_bit(offset, se->ckpt_valid_map))
> 1659         se->ckpt_valid_blocks += del;
> ...
> As a result, the ckpt_valid_blocks is always larger than valid_blocks. 
> If not correct, can you provide
> the case valid_blocks larger than ckpt_valid_blocks?

Oh, I just nit-pick, :), how about using 'se->ckpt_valid_blocks will never be
smaller than se->valid_blocks' instead?

And could you just revert Yunlei's patch and add above commit log?

Thanks,

> 
> On 2017/9/4 9:17, Chao Yu wrote:
>> On 2017/9/1 20:14, Yunlong Song wrote:
>>> se->ckpt_valid_blocks is always larger than se->valid_blocks, so
>>> get_ssr_cost can be cleared.
>> I think this is not correct.
>>
>> Thanks,
>>
>>> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
>>> ---
>>>   fs/f2fs/gc.c | 11 +----------
>>>   1 file changed, 1 insertion(+), 10 deletions(-)
>>>
>>> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
>>> index cd147e7..b226760 100644
>>> --- a/fs/f2fs/gc.c
>>> +++ b/fs/f2fs/gc.c
>>> @@ -277,20 +277,11 @@ static unsigned int get_greedy_cost(struct f2fs_sb_info *sbi,
>>>   				valid_blocks * 2 : valid_blocks;
>>>   }
>>>   
>>> -static unsigned int get_ssr_cost(struct f2fs_sb_info *sbi,
>>> -						unsigned int segno)
>>> -{
>>> -	struct seg_entry *se = get_seg_entry(sbi, segno);
>>> -
>>> -	return se->ckpt_valid_blocks > se->valid_blocks ?
>>> -				se->ckpt_valid_blocks : se->valid_blocks;
>>> -}
>>> -
>>>   static inline unsigned int get_gc_cost(struct f2fs_sb_info *sbi,
>>>   			unsigned int segno, struct victim_sel_policy *p)
>>>   {
>>>   	if (p->alloc_mode == SSR)
>>> -		return get_ssr_cost(sbi, segno);
>>> +		return get_seg_entry(sbi, segno)->ckpt_valid_blocks;
>>>   
>>>   	/* alloc_mode == LFS */
>>>   	if (p->gc_mode == GC_GREEDY)
>>>
>>
>> .
>>
>

[toc] | [prev] | [next] | [standalone]

#1725821 — [PATCH v2] Revert "f2fs: add a new function get_ssr_cost"

FromYunlong Song <yunlong.song@huawei.com>
Date2017-09-04 05:20 +0200
Subject[PATCH v2] Revert "f2fs: add a new function get_ssr_cost"
Message-ID<ulQ5A-9b-7@gated-at.bofh.it>
In reply to#1725011
This reverts commit b7b7c4cf1c9ef0272a65f1480457cbfdadcda19d.

se->ckpt_valid_blocks will never be smaller than se->valid_blocks, so just
remove get_ssr_cost.

Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
---
 fs/f2fs/gc.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
index cd147e7..b226760 100644
--- a/fs/f2fs/gc.c
+++ b/fs/f2fs/gc.c
@@ -277,20 +277,11 @@ static unsigned int get_greedy_cost(struct f2fs_sb_info *sbi,
 				valid_blocks * 2 : valid_blocks;
 }
 
-static unsigned int get_ssr_cost(struct f2fs_sb_info *sbi,
-						unsigned int segno)
-{
-	struct seg_entry *se = get_seg_entry(sbi, segno);
-
-	return se->ckpt_valid_blocks > se->valid_blocks ?
-				se->ckpt_valid_blocks : se->valid_blocks;
-}
-
 static inline unsigned int get_gc_cost(struct f2fs_sb_info *sbi,
 			unsigned int segno, struct victim_sel_policy *p)
 {
 	if (p->alloc_mode == SSR)
-		return get_ssr_cost(sbi, segno);
+		return get_seg_entry(sbi, segno)->ckpt_valid_blocks;
 
 	/* alloc_mode == LFS */
 	if (p->gc_mode == GC_GREEDY)
-- 
1.8.5.2

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web