Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1725797

Re: [PATCH] f2fs: clear get_ssr_cost

Show all headers | View raw

On 2017/9/1 20:14, Yunlong Song wrote:
> se->ckpt_valid_blocks is always larger than se->valid_blocks, so
> get_ssr_cost can be cleared.

I think this is not correct.

Thanks,

> 
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
>  fs/f2fs/gc.c | 11 +----------
>  1 file changed, 1 insertion(+), 10 deletions(-)
> 
> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c
> index cd147e7..b226760 100644
> --- a/fs/f2fs/gc.c
> +++ b/fs/f2fs/gc.c
> @@ -277,20 +277,11 @@ static unsigned int get_greedy_cost(struct f2fs_sb_info *sbi,
>  				valid_blocks * 2 : valid_blocks;
>  }
>  
> -static unsigned int get_ssr_cost(struct f2fs_sb_info *sbi,
> -						unsigned int segno)
> -{
> -	struct seg_entry *se = get_seg_entry(sbi, segno);
> -
> -	return se->ckpt_valid_blocks > se->valid_blocks ?
> -				se->ckpt_valid_blocks : se->valid_blocks;
> -}
> -
>  static inline unsigned int get_gc_cost(struct f2fs_sb_info *sbi,
>  			unsigned int segno, struct victim_sel_policy *p)
>  {
>  	if (p->alloc_mode == SSR)
> -		return get_ssr_cost(sbi, segno);
> +		return get_seg_entry(sbi, segno)->ckpt_valid_blocks;
>  
>  	/* alloc_mode == LFS */
>  	if (p->gc_mode == GC_GREEDY)
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] f2fs: clear get_ssr_cost Yunlong Song <yunlong.song@huawei.com> - 2017-09-01 14:20 +0200
  Re: [PATCH] f2fs: clear get_ssr_cost Chao Yu <yuchao0@huawei.com> - 2017-09-04 03:20 +0200
    Re: [PATCH] f2fs: clear get_ssr_cost Yunlong Song <yunlong.song@huawei.com> - 2017-09-04 04:00 +0200
      Re: [PATCH] f2fs: clear get_ssr_cost Chao Yu <yuchao0@huawei.com> - 2017-09-04 04:50 +0200
  [PATCH v2] Revert "f2fs: add a new function get_ssr_cost" Yunlong Song <yunlong.song@huawei.com> - 2017-09-04 05:20 +0200

csiph-web