Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723673 > unrolled thread

Re: [PATCH] vfio: platform: constify amba_id

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] vfio: platform: constify amba_id Alex Williamson <alex.williamson@redhat.com> - 2017-08-30 23:30 +0200

#1723673 — Re: [PATCH] vfio: platform: constify amba_id

On Wed, 23 Aug 2017 22:47:15 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/vfio/platform/vfio_amba.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/platform/vfio_amba.c b/drivers/vfio/platform/vfio_amba.c
> index 31372fb..62dfbfe 100644
> --- a/drivers/vfio/platform/vfio_amba.c
> +++ b/drivers/vfio/platform/vfio_amba.c
> @@ -93,7 +93,7 @@ static int vfio_amba_remove(struct amba_device *adev)
>  	return -EINVAL;
>  }
>  
> -static struct amba_id pl330_ids[] = {
> +static const struct amba_id pl330_ids[] = {
>  	{ 0, 0 },
>  };
>  

Applied to next branch for v4.14.  Thanks,

Alex

[toc] | [standalone]

Back to top | Article view | linux.kernel

csiph-web