Re: [PATCH] vfio: platform: constify amba_id

From	Alex Williamson <alex.williamson@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] vfio: platform: constify amba_id
Date	2017-08-30 23:30 +0200
Message-ID	<ukiIG-59S-23@gated-at.bofh.it> (permalink)
References	<uhHtT-3mE-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, 23 Aug 2017 22:47:15 +0530
Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:

> amba_id are not supposed to change at runtime. All functions
> working with const amba_id. So mark the non-const structs as const.
> 
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> ---
>  drivers/vfio/platform/vfio_amba.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/vfio/platform/vfio_amba.c b/drivers/vfio/platform/vfio_amba.c
> index 31372fb..62dfbfe 100644
> --- a/drivers/vfio/platform/vfio_amba.c
> +++ b/drivers/vfio/platform/vfio_amba.c
> @@ -93,7 +93,7 @@ static int vfio_amba_remove(struct amba_device *adev)
>  	return -EINVAL;
>  }
>  
> -static struct amba_id pl330_ids[] = {
> +static const struct amba_id pl330_ids[] = {
>  	{ 0, 0 },
>  };
>  

Applied to next branch for v4.14.  Thanks,

Alex

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH] vfio: platform: constify amba_id Alex Williamson <alex.williamson@redhat.com> - 2017-08-30 23:30 +0200

csiph-web