Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1723387 > unrolled thread
| Started by | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| First post | 2017-08-30 16:30 +0200 |
| Last post | 2017-09-07 16:40 +0200 |
| Articles | 5 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-30 16:30 +0200
Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches Larry Finger <Larry.Finger@lwfinger.net> - 2017-08-30 18:40 +0200
Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-30 19:00 +0200
Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches Larry Finger <Larry.Finger@lwfinger.net> - 2017-08-31 06:50 +0200
Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-09-07 16:40 +0200
| From | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| Date | 2017-08-30 16:30 +0200 |
| Subject | [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches |
| Message-ID | <ukcae-ZN-25@gated-at.bofh.it> |
Refactor code in order to avoid identical code for different branches.
This issue was detected with the help of Coccinelle.
Addresses-Coverity-ID: 1226788
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
This issue was reported by Coverity and it was tested by compilation only.
I'm suspicious this may be a copy/paste error. Please, verify.
.../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 10 ++--------
1 file changed, 2 insertions(+), 8 deletions(-)
diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
index c044252..960ce80f 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
@@ -2260,14 +2260,8 @@ static void halbtc8723b1ant_run_coexist_mechanism(struct btc_coexist *btcoexist)
if (iot_peer != BTC_IOT_PEER_CISCO &&
iot_peer != BTC_IOT_PEER_BROADCOM) {
- if (bt_link_info->sco_exist)
- halbtc8723b1ant_limited_rx(btcoexist,
- NORMAL_EXEC, false,
- false, 0x5);
- else
- halbtc8723b1ant_limited_rx(btcoexist,
- NORMAL_EXEC, false,
- false, 0x5);
+ halbtc8723b1ant_limited_rx(btcoexist, NORMAL_EXEC,
+ false, false, 0x5);
} else {
if (bt_link_info->sco_exist) {
halbtc8723b1ant_limited_rx(btcoexist,
--
2.5.0
[toc] | [next] | [standalone]
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Date | 2017-08-30 18:40 +0200 |
| Subject | Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches |
| Message-ID | <ukec2-2f2-7@gated-at.bofh.it> |
| In reply to | #1723387 |
On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Addresses-Coverity-ID: 1226788 > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > This issue was reported by Coverity and it was tested by compilation only. > I'm suspicious this may be a copy/paste error. Please, verify. I have referred this change to the engineers at Realtek. For the moment, please hold this patch. Thanks for reporting the condition. Larry
[toc] | [prev] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| Date | 2017-08-30 19:00 +0200 |
| Subject | Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches |
| Message-ID | <ukevo-2lz-13@gated-at.bofh.it> |
| In reply to | #1723488 |
Hi Larry, On 08/30/2017 11:37 AM, Larry Finger wrote: > On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: >> Refactor code in order to avoid identical code for different branches. >> >> This issue was detected with the help of Coccinelle. >> >> Addresses-Coverity-ID: 1226788 >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> This issue was reported by Coverity and it was tested by compilation >> only. >> I'm suspicious this may be a copy/paste error. Please, verify. > > I have referred this change to the engineers at Realtek. For the moment, > please hold this patch. > > Thanks for reporting the condition. > Glad to help. :) -- Gustavo A. R. Silva
[toc] | [prev] | [next] | [standalone]
| From | Larry Finger <Larry.Finger@lwfinger.net> |
|---|---|
| Date | 2017-08-31 06:50 +0200 |
| Subject | Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches |
| Message-ID | <ukpAu-12h-19@gated-at.bofh.it> |
| In reply to | #1723387 |
On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Addresses-Coverity-ID: 1226788 > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > This issue was reported by Coverity and it was tested by compilation only. > I'm suspicious this may be a copy/paste error. Please, verify. > > .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) This change is not correct. When bt_link_info->sco_exist is true, the call should be halbtc8723b1ant_limited_rx(btcoexist, NORMAL_EXEC, true, false, 0x5); NACK I will push the correct patch. Larry
[toc] | [prev] | [next] | [standalone]
| From | "Gustavo A. R. Silva" <gustavo@embeddedor.com> |
|---|---|
| Date | 2017-09-07 16:40 +0200 |
| Subject | Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches |
| Message-ID | <un68i-160-13@gated-at.bofh.it> |
| In reply to | #1723816 |
Hi Larry, On 08/30/2017 11:48 PM, Larry Finger wrote: > On 08/30/2017 08:42 AM, Gustavo A. R. Silva wrote: >> Refactor code in order to avoid identical code for different branches. >> >> This issue was detected with the help of Coccinelle. >> >> Addresses-Coverity-ID: 1226788 >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> This issue was reported by Coverity and it was tested by compilation >> only. >> I'm suspicious this may be a copy/paste error. Please, verify. >> >> .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c | 10 >> ++-------- >> 1 file changed, 2 insertions(+), 8 deletions(-) > > This change is not correct. When bt_link_info->sco_exist is true, the > call should be > > halbtc8723b1ant_limited_rx(btcoexist, > NORMAL_EXEC, true, > false, 0x5); > > NACK > > I will push the correct patch. > Great. Good to know. Thanks -- Gustavo A. R. Silva
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web