Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1723387

[PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different branches

Show all headers | View raw

Refactor code in order to avoid identical code for different branches.

This issue was detected with the help of Coccinelle.

Addresses-Coverity-ID: 1226788
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
---
This issue was reported by Coverity and it was tested by compilation only.
I'm suspicious this may be a copy/paste error. Please, verify.

 .../net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c   | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
index c044252..960ce80f 100644
--- a/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
+++ b/drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8723b1ant.c
@@ -2260,14 +2260,8 @@ static void halbtc8723b1ant_run_coexist_mechanism(struct btc_coexist *btcoexist)
 
 		if (iot_peer != BTC_IOT_PEER_CISCO &&
 		    iot_peer != BTC_IOT_PEER_BROADCOM) {
-			if (bt_link_info->sco_exist)
-				halbtc8723b1ant_limited_rx(btcoexist,
-							   NORMAL_EXEC, false,
-							   false, 0x5);
-			else
-				halbtc8723b1ant_limited_rx(btcoexist,
-							   NORMAL_EXEC, false,
-							   false, 0x5);
+			halbtc8723b1ant_limited_rx(btcoexist, NORMAL_EXEC,
+						   false, false, 0x5);
 		} else {
 			if (bt_link_info->sco_exist) {
 				halbtc8723b1ant_limited_rx(btcoexist,
-- 
2.5.0

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for different  branches "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-30 16:30 +0200
  Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for  different branches Larry Finger <Larry.Finger@lwfinger.net> - 2017-08-30 18:40 +0200
    Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for  different branches "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-08-30 19:00 +0200
  Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for  different branches Larry Finger <Larry.Finger@lwfinger.net> - 2017-08-31 06:50 +0200
    Re: [PATCH] rtlwifi: btcoex: 23b 1ant: fix duplicated code for  different branches "Gustavo A. R. Silva" <gustavo@embeddedor.com> - 2017-09-07 16:40 +0200

csiph-web